Remove unused prometheus metric service
What does this MR do and why?
Changes: Removes Projects::Prometheus::Metrics::DestroyService
& supporting BaseService
, which are unused.
Context: This MR cleans up a portion of dead code related to the removal of devopsmonitor Category:Metrics features. The Metrics Dashboard & Prometheus Metrics/Alerts (used for monitoring apps deploying using gitlab) were deprecated in 14.7 and removed from the product in 16.0.
- grouprespond related issue: Metrics: Delete models & database tables/columns (#397142 - closed)
- Monitor:Metrics removal epic: Monitor: Metrics Deprecation and Removal (&10107)
- Reference MR with all related removals: Draft: Remove all remaining metrics dashboard-r... (!160325 - closed)
- Metrics removal is blocking cells: Drop old unused tables for prometheus alerts (#461838 - closed)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
How to set up and validate locally
The features related to this removal were disabled in %16.0, and have been partially deleted since then. So there's nothing really to test here.
Merge request reports
Activity
changed milestone to %17.3
assigned to @syasonik
added pipelinetier-1 label
added sectionanalytics label
1 Warning The master pipeline status page reported failures in If these jobs fail in your merge request with the same errors, then they are not caused by your changes.
Please check for any on-going incidents in the incident issue tracker or in the#master-broken
Slack channel.1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @olaoluro
(UTC+1, 5 hours ahead of author)
@pskorupa
(UTC+2, 6 hours ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Piotr Skorupa
@Quintasan Could you do backend review for this removal MR?
requested review from @Quintasan
requested review from @pskorupa
added pipeline:mr-approved label
added pipelinetier-3 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for debf45a7expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 70 | 0 | 0 | 0 | 70 | ✅ | | Fulfillment | 1 | 0 | 0 | 0 | 1 | ✅ | | Govern | 71 | 0 | 0 | 0 | 71 | ✅ | | Verify | 43 | 0 | 2 | 0 | 45 | ✅ | | Create | 127 | 0 | 12 | 0 | 139 | ✅ | | Package | 16 | 0 | 15 | 0 | 31 | ✅ | | Data Stores | 30 | 0 | 1 | 0 | 31 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Secure | 2 | 0 | 0 | 0 | 2 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 375 | 0 | 31 | 0 | 406 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for debf45a7expand test summary
+---------------------------------------------------------------------+ | suites summary | +----------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------+--------+--------+---------+-------+-------+--------+ | Monitor | 12 | 0 | 13 | 0 | 25 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Create | 270 | 0 | 34 | 0 | 304 | ✅ | +----------------+--------+--------+---------+-------+-------+--------+ | Total | 284 | 0 | 48 | 0 | 332 | ✅ | +----------------+--------+--------+---------+-------+-------+--------+
mentioned in incident gitlab-org/quality/engineering-productivity/approved-mr-pipeline-incidents#920 (closed)
removed this merge request from the merge train because the pipeline did not succeed. Learn more.
@Quintasan @pskorupa Could one of you retry adding this to the merge train?
mentioned in commit 44fc361f
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowproduction label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
added groupanalytics instrumentation label and removed grouprespond label