Exclude PrometheusAlerts in count of issues with alerts in service ping

changed milestone to %17.3

added Category:Metrics backend devopsmonitor grouprespond maintenanceremoval typemaintenance labels

added analytics instrumentation analytics instrumentationreview pending labels

2 Warnings

For the following files, a review from the Data team and Analytics Instrumentation team is recommended
Please check the analytics instrumentation Service Ping guide or the Snowplow guide.

For MR review guidelines, see the Internal Analytics review guidelines.

spec/lib/gitlab/usage/metrics/instrumentations/issues_with_alert_management_alerts_metric_spec.rb
config/metrics/counts_all/20210216180441_issues_created_from_alerts.yml
ee/spec/lib/ee/gitlab/usage_data_spec.rb
lib/gitlab/usage/metrics/instrumentations/issues_with_alert_management_alerts_metric.rb
lib/gitlab/usage_data.rb
spec/lib/gitlab/usage_data_spec.rb
lib/gitlab/usage/metrics/instrumentations/issues_created_from_alerts_metric.rb
lib/gitlab/usage/metrics/instrumentations/issues_with_prometheus_alert_events.rb

The master pipeline status page reported failures in

If these jobs fail in your merge request with the same errors, then they are not caused by your changes.
Please check for any on-going incidents in the incident issue tracker or in the #master-broken Slack channel.

1 Message

CHANGELOG missing:

If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog.

If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Reviewer roulette

Category	Reviewer	Maintainer
analytics instrumentation	`@pskorupa` (UTC+2, 6 hours ahead of author)	Maintainer review is optional for analytics instrumentation
backend	`@subashis` (UTC-6, 2 hours behind author)	`@partiaga` (UTC+2, 6 hours ahead of author)

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

Generated by gitlab_quality-test_tooling.

Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.

Click to expand

Job	File	Name	Duration	Expected duration
#7411658643	`ee/spec/lib/ee/gitlab/usage_data_spec.rb#L214`	Gitlab::UsageData usage_activity_by_stage_create includes accurate usage_activity_by_stage data	28.53 s	< 27.12 s
#7411635974	`ee/spec/lib/ee/gitlab/usage_data_spec.rb#L214`	Gitlab::UsageData usage_activity_by_stage_create includes accurate usage_activity_by_stage data	30.78 s	< 27.12 s
#7431746428	`ee/spec/lib/ee/gitlab/usage_data_spec.rb#L214`	Gitlab::UsageData usage_activity_by_stage_create includes accurate usage_activity_by_stage data	35.4 s	< 27.12 s
#7431774629	`spec/lib/gitlab/usage_data_spec.rb#L454`	Gitlab::UsageData.data gathers usage data	27.57 s	< 27.12 s
#7431774810	`ee/spec/lib/ee/gitlab/usage_data_spec.rb#L214`	Gitlab::UsageData usage_activity_by_stage_create includes accurate usage_activity_by_stage data	41.65 s	< 27.12 s
#7432319372	`ee/spec/lib/ee/gitlab/usage_data_spec.rb#L214`	Gitlab::UsageData usage_activity_by_stage_create includes accurate usage_activity_by_stage data	39.27 s	< 27.12 s
#7432319336	`ee/spec/lib/ee/gitlab/usage_data_spec.rb#L214`	Gitlab::UsageData usage_activity_by_stage_create includes accurate usage_activity_by_stage data	34.37 s	< 27.12 s
#7440308732	`ee/spec/lib/ee/gitlab/usage_data_spec.rb#L214`	Gitlab::UsageData usage_activity_by_stage_create includes accurate usage_activity_by_stage data	36.73 s	< 27.12 s
#7440308475	`ee/spec/lib/ee/gitlab/usage_data_spec.rb#L214`	Gitlab::UsageData usage_activity_by_stage_create includes accurate usage_activity_by_stage data	32.63 s	< 27.12 s
#7454458510	`ee/spec/lib/ee/gitlab/usage_data_spec.rb#L214`	Gitlab::UsageData usage_activity_by_stage_create includes accurate usage_activity_by_stage data	32.66 s	< 27.12 s
#7454458448	`ee/spec/lib/ee/gitlab/usage_data_spec.rb#L214`	Gitlab::UsageData usage_activity_by_stage_create includes accurate usage_activity_by_stage data	41.61 s	< 27.12 s
#7466966817	`ee/spec/lib/ee/gitlab/usage_data_spec.rb#L214`	Gitlab::UsageData usage_activity_by_stage_create includes accurate usage_activity_by_stage data	33.04 s	< 27.12 s
#7474286977	`ee/spec/lib/ee/gitlab/usage_data_spec.rb#L214`	Gitlab::UsageData usage_activity_by_stage_create includes accurate usage_activity_by_stage data	32.33 s	< 27.12 s

added rspec:slow test detected label

marked this merge request as ready

changed the description

@pskorupa Could you do analytics instrumentation & backend review for this?

requested review from @pskorupa

added 852 commits

3e84d005...38b7bccd - 850 commits from branch master
385a999c - Exclude PrometheusAlerts in count of issues with alerts in service ping
37548f3d - Remove unneeded reference from usage_data.rb

Compare with previous version

requested review from @pskorupa

approved this merge request

removed review request for @pskorupa

added pipeline:mr-approved label

added pipelinetier-3 label and removed pipelinetier-1 label

Before you set this MR to auto-merge

This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

Before you set this MR to auto-merge, please check the following:

You are the last maintainer of this merge request
The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
This pipeline is recent enough (created in the last 8 hours)

If all the criteria above apply, please set auto-merge for this merge request.

See pipeline tiers and merging a merge request for more details.

requested review from @10io

E2E Test Result Summary

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for b4ed80ca

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Create      | 127    | 0      | 12      | 0     | 139   | ✅     |
| Plan        | 70     | 0      | 0       | 0     | 70    | ✅     |
| Verify      | 43     | 0      | 2       | 0     | 45    | ✅     |
| Govern      | 71     | 0      | 0       | 0     | 71    | ✅     |
| Data Stores | 30     | 0      | 1       | 0     | 31    | ✅     |
| Package     | 16     | 0      | 15      | 0     | 31    | ✅     |
| Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
| Secure      | 2      | 0      | 0       | 0     | 2     | ✅     |
| Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
| Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
| Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
| Fulfillment | 1      | 0      | 0       | 0     | 1     | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 375    | 0      | 31      | 0     | 406   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

e2e-package-and-test: test report for b4ed80ca

expand test summary

+---------------------------------------------------------------------+
|                           suites summary                            |
+----------------+--------+--------+---------+-------+-------+--------+
|                | passed | failed | skipped | flaky | total | result |
+----------------+--------+--------+---------+-------+-------+--------+
| GitLab Metrics | 2      | 0      | 1       | 0     | 3     | ✅     |
| Monitor        | 12     | 0      | 13      | 0     | 25    | ✅     |
| Create         | 270    | 0      | 34      | 0     | 304   | ✅     |
+----------------+--------+--------+---------+-------+-------+--------+
| Total          | 284    | 0      | 48      | 0     | 332   | ✅     |
+----------------+--------+--------+---------+-------+-------+--------+

approved this merge request

removed review request for @10io

added 1 commit

27a6ca5d - Remove reference to removed class

Compare with previous version

reset approvals from @10io and @pskorupa by pushing to the branch

added 505 commits

27a6ca5d...9ff78286 - 502 commits from branch master
42e08cf2 - Exclude PrometheusAlerts in count of issues with alerts in service ping
023d1958 - Remove unneeded reference from usage_data.rb
ef414bf0 - Remove reference to removed class

Compare with previous version