Remove unused metrics dashboard templates
What does this MR do and why?
Changes: This MR cleans up a portion of dead code related to the removal of devopsmonitor Category:Metrics features.
Scope: Everything under lib/gitlab/metrics/templates/
. These templates were originally made available as options for users to create new metrics dashboard yml files. That behavior has been removed.
Context: The Metrics Dashboard (used for monitoring apps deploying using gitlab) was deprecated in 14.7 and removed from the product in 16.0. There are many more files to remove related to this cleanup, but this should be a self-contained chunk.
- grouprespond related issue: Metrics: Delete models & database tables/columns (#397142 - closed)
- Monitor:Metrics removal epic: Monitor: Metrics Deprecation and Removal (&10107)
- Reference MR with all related removals: Draft: Remove all remaining metrics dashboard-r... (!160325 - closed)
- Metrics removal is blocking cells: Drop old unused tables for prometheus alerts (#461838 - closed)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
How to set up and validate locally
These features were disabled in %16.0 behind the :remove_monitor_metrics
feature flag, and have been partially deleted since then. So there's nothing really to test here. It's no longer possible to set up these features.
Merge request reports
Activity
changed milestone to %17.3
assigned to @syasonik
added pipelinetier-1 label
added sectionanalytics label
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerremoved backend label
- Resolved by Jose Ivan Vargas
@jivanvl Could you review this MR? (an old Category:Metrics removal)
requested review from @jivanvl
added pipeline:mr-approved label
added pipelinetier-3 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
mentioned in issue jivanvl/manager-of-one#16 (closed)
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 0ac1a178expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 127 | 0 | 12 | 0 | 139 | ✅ | | Data Stores | 31 | 0 | 0 | 0 | 31 | ✅ | | Plan | 63 | 0 | 6 | 0 | 69 | ✅ | | Verify | 43 | 0 | 2 | 0 | 45 | ✅ | | Fulfillment | 1 | 0 | 0 | 0 | 1 | ✅ | | Govern | 69 | 0 | 0 | 0 | 69 | ✅ | | Package | 19 | 0 | 12 | 0 | 31 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Secure | 1 | 0 | 0 | 0 | 1 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 369 | 0 | 33 | 0 | 402 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 0ac1a178expand test summary
+---------------------------------------------------------------------+ | suites summary | +----------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------+--------+--------+---------+-------+-------+--------+ | Monitor | 12 | 0 | 13 | 0 | 25 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Create | 278 | 0 | 34 | 66 | 312 | ✅ | | Govern | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 6 | 0 | 2 | 0 | 8 | ✅ | +----------------+--------+--------+---------+-------+-------+--------+ | Total | 302 | 0 | 50 | 66 | 352 | ✅ | +----------------+--------+--------+---------+-------+-------+--------+
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in commit 65e24484
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
added groupanalytics instrumentation label and removed grouprespond label