Fix superfluous space in titles on merge train page
What does this MR do and why?
This removes the superfluous trailing space from MR titles on the new merge train page.
Screenshots or screen recordings
What | Before | After |
---|---|---|
List entry |
![]() |
![]() |
Car removal modal |
![]() |
![]() |
How to set up and validate locally
- Go to a project
- Enable the
merge_train_viz
feature flag in the project (e.g.Feature.enable(:merge_train_viz, Project.find(id))
whereid
is your project ID) until !160262 (merged) is merged - Enable merge trains
- Enable merged results pipelines: https://docs.gitlab.com/ee/ci/pipelines/merge_request_pipelines.html#prerequisites
- Create a long-running job (e.g. by adding a
sleep 60
command) that runs in merge trains, so you have enough time to test - Create an MR
- Start a merge train
- Go to the merge train page
- See that there is no longer a trailing space in the link
- Click on the X icon
- See that there is no longer a trailing space in the MR title
<code>
block
Merge request reports
Activity
assigned to @kkloss
added typebug label
added typemaintenance label and removed typebug label
added pipelinetier-1 label
added UI polish grouppipeline execution labels and removed pipelinetier-1 label
added devopsverify sectionci labels
added pipelinetier-1 label
- A deleted user
added frontend label
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer frontend @rhardarson
(UTC+2, same timezone as author)
@ntepluhina
(UTC+2, same timezone as author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Payton Burdette
@pburdette, I’ve been a tiny bit bugged by this for a few days now (love to see the merge train visualized though, good work!).
Could you please review this?
changed milestone to %17.3
added feature flagexists label
requested review from @pburdette
added pipeline:mr-approved label
added pipelinetier-3 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.