Classify schema and sharding for the search_indices table

changed milestone to %17.3

added database devopsdata stores groupglobal search maintenancerefactor sectioncore platform typemaintenance labels

requested review from @terrichu and @johnmason

@terrichu @johnmason Can you review this, please? Apparently, the search_indices table is empty #442663 (comment 2007643014).

mentioned in issue #442663 (closed)

added pipelinetier-1 label

added databasereview pending label

1 Warning

The master pipeline status page reported failures in

If these jobs fail in your merge request with the same errors, then they are not caused by your changes.
Please check for any on-going incidents in the incident issue tracker or in the #master-broken Slack channel.

Reviewer roulette

Category	Reviewer	Maintainer
database	`@ck3g` (UTC+2, same timezone as author)	`@a_akgun` (UTC+3, 1 hour ahead of author)

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

approved this merge request

added pipeline:mr-approved label

added pipelinetier-2 label and removed pipelinetier-1 label

Before you set this MR to auto-merge

This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

Before you set this MR to auto-merge, please check the following:

You are the last maintainer of this merge request
The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
This pipeline is recent enough (created in the last 8 hours)

If all the criteria above apply, please set auto-merge for this merge request.

See pipeline tiers and merging a merge request for more details.

removed review request for @terrichu

Approving and setting MWPS

resolved all threads

approved this merge request

Three attempts to run a new pipeline and they are all failing.

I'm going to try to /rebase and start MWPS.

added 134 commits

d52837f1...e75d0040 - 133 commits from branch master
d25d268a - Classify schema and sharding for search_indices table

Compare with previous version

enabled automatic add to merge train when checks pass

E2E Test Result Summary

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for 145380d0

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Verify      | 44     | 0      | 3       | 0     | 47    | ✅     |
| Create      | 127    | 0      | 12      | 0     | 139   | ✅     |
| Data Stores | 31     | 0      | 0       | 0     | 31    | ✅     |
| Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
| Govern      | 69     | 0      | 0       | 0     | 69    | ✅     |
| Plan        | 67     | 0      | 2       | 0     | 69    | ✅     |
| Package     | 19     | 0      | 12      | 0     | 31    | ✅     |
| Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
| Fulfillment | 1      | 0      | 0       | 0     | 1     | ✅     |
| Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
| Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 373    | 0      | 30      | 0     | 403   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

e2e-package-and-test: test report for 145380d0

expand test summary

+---------------------------------------------------------------------+
|                           suites summary                            |
+----------------+--------+--------+---------+-------+-------+--------+
|                | passed | failed | skipped | flaky | total | result |
+----------------+--------+--------+---------+-------+-------+--------+
| Plan           | 88     | 0      | 11      | 0     | 99    | ✅     |
| Create         | 425    | 0      | 51      | 60    | 476   | ✅     |
| Govern         | 108    | 0      | 9       | 2     | 117   | ✅     |
| Fulfillment    | 4      | 0      | 7       | 0     | 11    | ✅     |
| Verify         | 51     | 1      | 14      | 1     | 66    | ❌     |
| Package        | 31     | 0      | 14      | 6     | 45    | ✅     |
| Systems        | 7      | 0      | 0       | 0     | 7     | ✅     |
| Data Stores    | 47     | 0      | 10      | 0     | 57    | ✅     |
| Manage         | 30     | 0      | 15      | 2     | 45    | ✅     |
| GitLab Metrics | 2      | 0      | 1       | 0     | 3     | ✅     |
| Analytics      | 3      | 0      | 0       | 0     | 3     | ✅     |
| Monitor        | 12     | 0      | 13      | 0     | 25    | ✅     |
| Configure      | 1      | 0      | 3       | 0     | 4     | ✅     |
| Ai-powered     | 1      | 0      | 2       | 0     | 3     | ✅     |
| Secure         | 3      | 0      | 2       | 0     | 5     | ✅     |
| Growth         | 0      | 0      | 2       | 0     | 2     | ➖     |
| Release        | 5      | 0      | 1       | 0     | 6     | ✅     |
| ModelOps       | 0      | 0      | 1       | 0     | 1     | ➖     |
+----------------+--------+--------+---------+-------+-------+--------+
| Total          | 818    | 1      | 156     | 71    | 975   | ❌     |
+----------------+--------+--------+---------+-------+-------+--------+

requested review from @a_akgun

mentioned in issue #473381 (closed)

approved this merge request

added pipelinetier-3 label and removed pipelinetier-2 label

added databaseapproved pipelinetier-2 labels and removed databasereview pending pipelinetier-3 labels

resolved all threads

started a merge train

removed this merge request from the merge train because pipeline did not succeed. Learn more.

added pipelinetier-3 label and removed pipelinetier-2 label

I believe we can set pipelinetier-3 as we have all the necessary approvals.

Reference: https://docs.gitlab.com/ee/development/pipelines/#pipeline-tiers

started a merge train

removed this merge request from the merge train because pipeline did not succeed. Learn more.

Okay, I will rebase to fix the pipeline errors.

added 89 commits

d25d268a...a8623cda - 88 commits from branch master
145380d0 - Classify schema and sharding for search_indices table

Compare with previous version

started a merge train

merged

Hello @arturoherrero

The database team is looking for ways to improve the database review process and we would love your help!

If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning: