Update structure.sql
What does this MR do and why?
Add missing comma after !158372 (merged).
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Merge request reports
Activity
changed milestone to %17.3
added groupdatabase maintenancerefactor typemaintenance labels
assigned to @krasio
added pipelinetier-1 label
added Category:Database devopsdata stores sectioncore platform labels
@tigerwnz can you please have a look and merge? This is another case of missing comma being a valid syntax, but not the one used by pg_dump.
requested review from @tigerwnz
- A deleted user
added database databasereview pending labels
1 Warning 9c074415: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. Reviewer roulette
Category Reviewer Maintainer database @ck3g
(UTC+2, 10 hours behind author)
@OmarQunsulGitlab
(UTC+2, 10 hours behind author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost User- A deleted user
added Data WarehouseImpact Check label
added databaseapproved label and removed databasereview pending label
added pipeline:mr-approved label
added pipelinetier-3 label and removed pipelinetier-1 label
- Resolved by Tiger Watson
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you resolve this discussion, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please resolve this discussion and the set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 9c074415expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 67 | 0 | 2 | 0 | 69 | ✅ | | Verify | 44 | 0 | 3 | 0 | 47 | ✅ | | Create | 128 | 0 | 12 | 0 | 140 | ✅ | | Govern | 69 | 0 | 0 | 0 | 69 | ✅ | | Data Stores | 31 | 0 | 0 | 0 | 31 | ✅ | | Package | 19 | 0 | 12 | 0 | 31 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Fulfillment | 1 | 0 | 0 | 0 | 1 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 374 | 0 | 30 | 0 | 404 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 9c074415expand test summary
+---------------------------------------------------------------------+ | suites summary | +----------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------+--------+--------+---------+-------+-------+--------+ | Create | 419 | 0 | 51 | 60 | 470 | ✅ | | Govern | 106 | 0 | 9 | 2 | 115 | ✅ | | Systems | 7 | 0 | 0 | 0 | 7 | ✅ | | Manage | 30 | 0 | 15 | 2 | 45 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Monitor | 12 | 0 | 13 | 0 | 25 | ✅ | | Fulfillment | 4 | 0 | 7 | 0 | 11 | ✅ | | Analytics | 3 | 0 | 0 | 0 | 3 | ✅ | | Package | 31 | 0 | 14 | 5 | 45 | ✅ | | Data Stores | 47 | 0 | 10 | 0 | 57 | ✅ | | Plan | 84 | 0 | 11 | 0 | 95 | ✅ | | Verify | 52 | 0 | 14 | 0 | 66 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Configure | 1 | 0 | 3 | 0 | 4 | ✅ | | Ai-powered | 1 | 0 | 1 | 0 | 2 | ✅ | | Secure | 3 | 0 | 2 | 0 | 5 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | +----------------+--------+--------+---------+-------+-------+--------+ | Total | 807 | 0 | 155 | 69 | 962 | ✅ | +----------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost UserHello @krasio
The database team is looking for ways to improve the database review process and we would love your help!
If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning:
@gitlab-org/database-team
And someone will be by shortly!
Thanks for your help!
This message was generated automatically. You're welcome to improve it.
mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#7444 (closed)
mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#7445 (closed)
added Data WarehouseNot Impacted label and removed Data WarehouseImpact Check label
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in merge request !160984 (merged)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
added groupdatabase frameworks label and removed groupdatabase [DEPRECATED] label