Use a low statement timeout in load balancer
What does this MR do and why?
Lowers statement timeout in the load balancer to 100ms to help with Improve application database load balancing log... (#472161)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Merge request reports
Activity
assigned to @stomlinson
mentioned in issue #472161
added pipelinetier-1 label
- A deleted user
added backend database databasereview pending labels
1 Warning The master pipeline status page reported failures in - rspec-ee migration pg14 2/2
- rspec unit pg14 14/44
- rspec migration pg14 26/26
- rspec migration pg14 23/26
- rspec migration pg14 20/26
- rspec migration pg14 17/26
- rspec migration pg14 16/26
- rspec migration pg14 13/26
- rspec migration pg14 12/26
- rspec migration pg14 5/26
- rspec migration pg14 3/26
- rspec migration pg14 2/26
- rspec-ee unit pg14 single-db-ci-connection 26/39
- rspec-ee unit pg14 single-db 32/39
- rspec integration pg14 single-db 1/20
- rspec unit pg14 single-db-ci-connection 35/44
- rspec unit pg14 single-db-ci-connection 11/44
- rspec unit pg14 single-db-ci-connection 1/44
- rspec unit pg14 single-db 14/44
- rspec unit pg14 single-db 6/44
- rspec unit pg14 single-redis 36/44
If these jobs fail in your merge request with the same errors, then they are not caused by your changes.
Please check for any on-going incidents in the incident issue tracker or in the#master-broken
Slack channel.1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @shubhamkrai
(UTC+2, 7 hours ahead of author)
@eugielimpin
(UTC+8, 13 hours ahead of author)
database @bmarjanovic
(UTC+2, 7 hours ahead of author)
@mbobin
(UTC+3, 8 hours ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Simon Tomlinson
@stomlinson
- please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request.
added groupdatabase label
added Category:Database devopsdata stores sectioncore platform labels
- Resolved by Simon Tomlinson
- Resolved by Simon Tomlinson
added pipeline:run-all-rspec label
- A deleted user
added feature flag label
- Resolved by Simon Tomlinson
added 2554 commits
-
86909617...d85d4755 - 2553 commits from branch
master
- 0bdb394b - Low statement timeout for lb health checks
-
86909617...d85d4755 - 2553 commits from branch
- Resolved by Simon Tomlinson
@mattkasa can you take a first look here? I think this is feature complete but I'm curious if you can think of any more tests or anything else we can do to make this safer.
requested review from @mattkasa
changed milestone to %17.3
- Resolved by Matt Kasa
mentioned in merge request container-registry!1709 (merged)
mentioned in merge request !161646
mentioned in issue gitlab-org/database-team/team-tasks#445 (closed)
mentioned in issue container-registry#1322 (closed)
Security policy violations have been resolved.
Edited by GitLab Security Botadded 2723 commits
-
df35e856...f0f27e2e - 2722 commits from branch
master
- fec03035 - Low statement timeout for lb health checks
-
df35e856...f0f27e2e - 2722 commits from branch
changed milestone to %17.4
added missed:17.3 label
added 1438 commits
-
00c9e31b...9e8992e9 - 1435 commits from branch
master
- 590be1fe - Low statement timeout for lb health checks
- 70ba87ef - Test for when feature flag is disabled
- 294076f9 - Increase load balancer statement timeout to 100ms
Toggle commit list-
00c9e31b...9e8992e9 - 1435 commits from branch
requested review from @jon_jenkins
- Resolved by Simon Tomlinson
added pipeline:mr-approved label
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
added 2294 commits
-
294076f9...f91401d0 - 2290 commits from branch
master
- 7fe47bdd - Low statement timeout for lb health checks
- 2dbb373b - Test for when feature flag is disabled
- b2594760 - Increase load balancer statement timeout to 100ms
- 584c0972 - Fix feature flag rollout yaml
Toggle commit list-
294076f9...f91401d0 - 2290 commits from branch
reset approvals from @mattkasa and @jon_jenkins by pushing to the branch
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for e6924e2dexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 88 | 0 | 4 | 0 | 92 | ✅ | | Monitor | 16 | 0 | 0 | 0 | 16 | ✅ | | Create | 256 | 0 | 32 | 0 | 288 | ✅ | | Plan | 148 | 0 | 2 | 0 | 150 | ✅ | | Package | 40 | 0 | 24 | 0 | 64 | ✅ | | Govern | 144 | 0 | 0 | 0 | 144 | ✅ | | Data Stores | 62 | 0 | 2 | 0 | 64 | ✅ | | Analytics | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 2 | 0 | 2 | 0 | 4 | ✅ | | Secure | 8 | 0 | 0 | 0 | 8 | ✅ | | Fulfillment | 4 | 0 | 0 | 0 | 4 | ✅ | | Release | 10 | 0 | 0 | 0 | 10 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 782 | 0 | 66 | 0 | 848 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-omnibus:
test report for 584c0972expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 160 | 0 | 12 | 4 | 172 | ✅ | | Data Stores | 66 | 0 | 20 | 0 | 86 | ✅ | | Create | 538 | 0 | 72 | 0 | 610 | ✅ | | Plan | 162 | 0 | 18 | 0 | 180 | ✅ | | Verify | 102 | 0 | 30 | 8 | 132 | ✅ | | Monitor | 16 | 0 | 24 | 0 | 40 | ✅ | | Manage | 4 | 0 | 16 | 0 | 20 | ✅ | | Package | 48 | 0 | 28 | 0 | 76 | ✅ | | Analytics | 4 | 0 | 0 | 0 | 4 | ✅ | | Fulfillment | 4 | 0 | 14 | 0 | 18 | ✅ | | Growth | 0 | 0 | 4 | 0 | 4 | ➖ | | Secure | 8 | 0 | 4 | 0 | 12 | ✅ | | Ai-powered | 0 | 0 | 4 | 0 | 4 | ➖ | | Release | 10 | 0 | 2 | 0 | 12 | ✅ | | Configure | 0 | 0 | 6 | 0 | 6 | ➖ | | ModelOps | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 1122 | 0 | 256 | 12 | 1378 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
removed pipeline:run-e2e-omnibus-once label
mentioned in issue gitlab-org/database-team/team-tasks#453 (closed)
added bugavailability typebug labels
added 1374 commits
-
584c0972...c0dab637 - 1370 commits from branch
master
- 518ef5b7 - Low statement timeout for lb health checks
- b802ae47 - Test for when feature flag is disabled
- a4e51086 - Increase load balancer statement timeout to 100ms
- e6924e2d - Fix feature flag rollout yaml
Toggle commit list-
584c0972...c0dab637 - 1370 commits from branch
added databaseapproved label and removed databasereview pending label
added this merge request to the merge train at position 2
Hello @stomlinson
The database team is looking for ways to improve the database review process and we would love your help!
If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning:
@gitlab-org/database-team
And someone will be by shortly!
Thanks for your help!
This message was generated automatically. You're welcome to improve it.
mentioned in commit 3d7bad92
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in incident gitlab-com/gl-infra/production#18565 (closed)
mentioned in incident gitlab-org/release/tasks#13226 (closed)
mentioned in merge request container-registry!1808 (merged)
added releasedpublished label and removed releasedcandidate label
mentioned in issue gitlab-org/quality/triage-reports#20618 (closed)
mentioned in issue gitlab-org/quality/triage-reports#20984 (closed)
mentioned in issue gitlab-org/quality/triage-reports#21521 (closed)
added groupdatabase frameworks label and removed groupdatabase [DEPRECATED] label
mentioned in issue gitlab-org/quality/triage-reports#22040