Skip to content
Snippets Groups Projects

Use a low statement timeout in load balancer

Merged Simon Tomlinson requested to merge stomlinson/load-balancing-handle-timeouts into master
All threads resolved!

What does this MR do and why?

Lowers statement timeout in the load balancer to 100ms to help with Improve application database load balancing log... (#472161)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • A deleted user added feature flag label

    added feature flag label

  • Ghost User
  • Simon Tomlinson added 2554 commits

    added 2554 commits

    Compare with previous version

  • added 1 commit

    • 2d5ba3e4 - Low statement timeout for lb health checks

    Compare with previous version

  • added 1 commit

    • 1b21daef - Low statement timeout for lb health checks

    Compare with previous version

  • Simon Tomlinson requested review from @mattkasa

    requested review from @mattkasa

  • Simon Tomlinson changed milestone to %17.3

    changed milestone to %17.3

  • added 1 commit

    • df35e856 - Low statement timeout for lb health checks

    Compare with previous version

  • Matt Kasa
  • Simon Tomlinson mentioned in merge request !161646

    mentioned in merge request !161646

  • Security policy violations have been resolved.

    Edited by GitLab Security Bot
  • Simon Tomlinson added 2723 commits

    added 2723 commits

    Compare with previous version

  • changed milestone to %17.4

  • added 1 commit

    • 00c9e31b - Test for when feature flag is disabled

    Compare with previous version

  • Simon Tomlinson added 1438 commits

    added 1438 commits

    • 00c9e31b...9e8992e9 - 1435 commits from branch master
    • 590be1fe - Low statement timeout for lb health checks
    • 70ba87ef - Test for when feature flag is disabled
    • 294076f9 - Increase load balancer statement timeout to 100ms

    Compare with previous version

  • Simon Tomlinson marked this merge request as ready

    marked this merge request as ready

  • requested review from @jon_jenkins

  • Matt Kasa
  • Matt Kasa approved this merge request

    approved this merge request

  • Before you set this MR to auto-merge

    This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

    Before you set this MR to auto-merge, please check the following:

    • You are the last maintainer of this merge request
    • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
    • This pipeline is recent enough (created in the last 8 hours)

    If all the criteria above apply, please set auto-merge for this merge request.

    See pipeline tiers and merging a merge request for more details.

  • Jon Jenkins approved this merge request

    approved this merge request

  • Simon Tomlinson added 2294 commits

    added 2294 commits

    • 294076f9...f91401d0 - 2290 commits from branch master
    • 7fe47bdd - Low statement timeout for lb health checks
    • 2dbb373b - Test for when feature flag is disabled
    • b2594760 - Increase load balancer statement timeout to 100ms
    • 584c0972 - Fix feature flag rollout yaml

    Compare with previous version

  • Simon Tomlinson reset approvals from @mattkasa and @jon_jenkins by pushing to the branch

    reset approvals from @mattkasa and @jon_jenkins by pushing to the branch

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for e6924e2d

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Verify      | 88     | 0      | 4       | 0     | 92    | ✅     |
    | Monitor     | 16     | 0      | 0       | 0     | 16    | ✅     |
    | Create      | 256    | 0      | 32      | 0     | 288   | ✅     |
    | Plan        | 148    | 0      | 2       | 0     | 150   | ✅     |
    | Package     | 40     | 0      | 24      | 0     | 64    | ✅     |
    | Govern      | 144    | 0      | 0       | 0     | 144   | ✅     |
    | Data Stores | 62     | 0      | 2       | 0     | 64    | ✅     |
    | Analytics   | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Manage      | 2      | 0      | 2       | 0     | 4     | ✅     |
    | Secure      | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Fulfillment | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Release     | 10     | 0      | 0       | 0     | 10    | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 782    | 0      | 66      | 0     | 848   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-omnibus: :white_check_mark: test report for 584c0972

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Govern      | 160    | 0      | 12      | 4     | 172   | ✅     |
    | Data Stores | 66     | 0      | 20      | 0     | 86    | ✅     |
    | Create      | 538    | 0      | 72      | 0     | 610   | ✅     |
    | Plan        | 162    | 0      | 18      | 0     | 180   | ✅     |
    | Verify      | 102    | 0      | 30      | 8     | 132   | ✅     |
    | Monitor     | 16     | 0      | 24      | 0     | 40    | ✅     |
    | Manage      | 4      | 0      | 16      | 0     | 20    | ✅     |
    | Package     | 48     | 0      | 28      | 0     | 76    | ✅     |
    | Analytics   | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Fulfillment | 4      | 0      | 14      | 0     | 18    | ✅     |
    | Growth      | 0      | 0      | 4       | 0     | 4     | ➖     |
    | Secure      | 8      | 0      | 4       | 0     | 12    | ✅     |
    | Ai-powered  | 0      | 0      | 4       | 0     | 4     | ➖     |
    | Release     | 10     | 0      | 2       | 0     | 12    | ✅     |
    | Configure   | 0      | 0      | 6       | 0     | 6     | ➖     |
    | ModelOps    | 0      | 0      | 2       | 0     | 2     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 1122   | 0      | 256     | 12    | 1378  | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • Jon Jenkins approved this merge request

    approved this merge request

  • Simon Tomlinson added 1374 commits

    added 1374 commits

    • 584c0972...c0dab637 - 1370 commits from branch master
    • 518ef5b7 - Low statement timeout for lb health checks
    • b802ae47 - Test for when feature flag is disabled
    • a4e51086 - Increase load balancer statement timeout to 100ms
    • e6924e2d - Fix feature flag rollout yaml

    Compare with previous version

  • added databaseapproved label and removed databasereview pending label

  • Matt Kasa approved this merge request

    approved this merge request

  • Matt Kasa resolved all threads

    resolved all threads

  • Simon Tomlinson added this merge request to the merge train at position 2

    added this merge request to the merge train at position 2

  • Hello @stomlinson :wave:

    The database team is looking for ways to improve the database review process and we would love your help!

    If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning:

    @gitlab-org/database-team

    And someone will be by shortly!

    Thanks for your help! :heart:

    This message was generated automatically. You're welcome to improve it.

  • mentioned in commit 3d7bad92

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading