Resolve "Use semantic tokens in app/assets/stylesheets/components/avatar.scss"
What does this MR do and why?
Uses semantic tokens instead of fixed value tokens in avatar sass file
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Start with the GDK on the
master
branch of gitlab - In the GDK, change the avatar of a user who is not allowed to merge in a project to a transparent png (so that you can see the background and inset shadow of their avatar. I used this transparent png.
- Visit an MR in a project where that user is not allowed to merge and add that use as an assignee or reviewer
- Look at the user's avatar and hover over the avatar to get their profile popover
- Check out this branch and refresh the page after ensuring that the GDK is functioning normally (you may need to
yarn install
or run db migrations) - Look at that user's avatar again. You should not see any significant visual difference in their avatar or their profile popover. The avatar's border color will be very slightly different, but in a way that is not readily apparent without close scrutiny.
Related to #472683 (closed), #452231 (closed)
Merge request reports
Activity
changed milestone to %17.3
assigned to @clavimoniere
added 1 commit
- 738d4192 - Use semantic tokens in app/assets/stylesheets/components/avatar.scss
- A deleted user
added frontend label
Reviewer roulette
Category Reviewer Maintainer frontend @marina.mosti
(UTC+2, 6 hours ahead of author)
@tristan.read
(UTC+12, 16 hours ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Chad Lavimoniere
@danmh can you do a UX review on this?
requested review from @danmh
- Resolved by Chad Lavimoniere
- Resolved by Chad Lavimoniere
- Resolved by Chad Lavimoniere
- Resolved by Chad Lavimoniere
issue: I believe it is not optimal to use scss variables, instead use css custom properties. Hopefully @sdejonge can confirm?
added 1 commit
- 1cf5c1dc - Use semantic tokens in app/assets/stylesheets/components/avatar.scss
mentioned in issue #473284
- Resolved by Chad Lavimoniere
added pipeline:mr-approved label