Remove search_add_fork_filter_to_zoekt FF

What does this MR do and why?

Related to #470418 (closed)

This feature removes the search_add_fork_filter_to_zoekt feature flag and adds a few tests I saw were missing

The flag is fully enabled in production as of 18:20 UTC 2024-07-11

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

How to set up and validate locally

1. enable zoekt for gdk
2. ensure the user preferences for Exact code search is enabled for your gdk user
3. pick a group to index into zoekt
4. create a forked project into that group
5. run a group search for the group indexed into zoekt
6. verify that the forks filter is available, it defaults to on, so the forked project should not show up in code results
7. select the include forks filter
8. verify that the forked project results do show up

changed milestone to %17.2

added devopsdata stores feature flag featureenhancement groupglobal search sectioncore platform typefeature workflowin dev labels

assigned to @terrichu

added pipelinetier-1 label

added backend frontend labels

	1 Warning
	featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart. For more information, see: The Handbook page on merge request types. The definition of done documentation.

Reviewer roulette

Category	Reviewer	Maintainer
backend	@tigerwnz (UTC+12, 16 hours ahead of author)	@brytannia (UTC+2, 6 hours ahead of author)
frontend	@kpalchyk (UTC+3, 7 hours ahead of author)	@himkp (UTC+2, 6 hours ahead of author)

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

Generated by gitlab_quality-test_tooling.

---

Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.

Click to expand

Job	File	Name	Duration	Expected duration
#7345463397	ee/spec/requests/search_controller_spec.rb#L58	SearchController GET /search when elasticsearch is enabled for issues scope behaves like an efficient database result avoids N+1 database queries	21.11 s	< 19.2 s
#7430742449	ee/spec/requests/search_controller_spec.rb#L63	SearchController GET /search when elasticsearch is enabled for issues scope when search_issue_refactor flag is false behaves like an efficient database result avoids N+1 database queries	27.34 s	< 19.2 s

added rspec:slow test detected label

changed milestone to %17.3

changed the description

added 1131 commits

• 090af177...927c5f85 - 1130 commits from branch master
• e6ca971d - Remove search_add_fork_filter_to_zoekt FF

Compare with previous version

added 1 commit

• 5dcbe6a7 - Remove search_add_fork_filter_to_zoekt FF

Compare with previous version

added 693 commits

• 5dcbe6a7...2d9968d1 - 692 commits from branch master
• 2fd10fdc - Remove search_add_fork_filter_to_zoekt FF

Compare with previous version

marked this merge request as ready

@ibaum would you mind an initial backend review? can you send over to @rkumar555 or @dgruzd for maintainer?

requested review from @ibaum

@eduardobonet would you mind an initial frontend review? please send to @tbulva for maintainer

requested review from @eduardobonet

removed workflowin dev label

approved this merge request