Update the token expiration banner (17.0)
What does this MR do and why?
Bringing changes !159231 (merged) in master to 17-0 backport.
Related to gitlab-org/release/tasks#11507 (closed).
Update the token expiration banner
First commit:
- hide banner depending on
GITLAB_DISABLE_TOKEN_EXPIRATION_BANNER
env variable - updated banner message and use a namespace
Second commit:
- Show the token expiration banner only when the database migration job
CleanupPersonalAccessTokensWithNilExpiresAt
(https://gitlab.com/gitlab-org/gitlab/-/blob/master/db/docs/batched_background_migrations/cleanup_personal_access_tokens_with_nil_expires_at.yml) has run.CleanupPersonalAccessTokensWithNilExpiresAt
database migration job turned non-expiring tokens (expires_atnil
) to expiring.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
No changes.
How to set up and validate locally
Pass tests
Merge request reports
Activity
added bugux groupauthentication typebug labels
assigned to @eduardosanz
added devopsgovern sectionsec labels
- A deleted user
added backend documentation frontend labels
2 Warnings Backporting to older releases requires an exception request process The e2e:package-and-test-ee
job needs to succeed or have approval from a Software Engineer in Test.
Read the "QA e2e:package-and-test-ee" section for more details.2 Messages CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/administration/environment_variables.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Category Reviewer Maintainer backend @arpitgogia
(UTC+5.5, 3.5 hours ahead of author)
@rkadam3
(UTC+5.5, 3.5 hours ahead of author)
frontend @dftian
(UTC-10, 12 hours behind author)
@blabuschagne
(UTC+2, same timezone as author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
QA
e2e:package-and-test-ee
@eduardosanz, the
package-and-test
job must complete before merging this merge request.*If there are failures on the
package-and-test
pipeline, ping your team's associated Software Engineer in Test (SET) to confirm the failures are unrelated to the merge request. If there's no SET assigned, ask for assistance on the#test-platform
Slack channel.If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
changed milestone to %17.3
mentioned in issue gitlab-org/release/tasks#11507 (closed)
- Resolved by Sofia Vistas
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-package-and-test:
test report for a800a414expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 284 | 16 | 13 | 4 | 313 | ❌ | | Create | 209 | 111 | 34 | 48 | 354 | ❌ | | Plan | 26 | 18 | 4 | 0 | 48 | ❌ | | Data Stores | 17 | 5 | 0 | 0 | 22 | ❌ | | Release | 2 | 0 | 0 | 0 | 2 | ✅ | | Verify | 7 | 3 | 0 | 0 | 10 | ❌ | | Monitor | 4 | 4 | 0 | 0 | 8 | ❌ | | Package | 6 | 0 | 8 | 0 | 14 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 555 | 157 | 59 | 52 | 771 | ❌ | +-------------+--------+--------+---------+-------+-------+--------+
- Resolved by Sofia Vistas
@eduardosanz Thee2e:package-and-test-ee
job has failed.-
e2e:package-and-test-ee
pipeline: https://gitlab.com/gitlab-org/gitlab/-/pipelines/1375570025
e2e:package-and-test-ee
pipeline is allowed to fail due its flakiness. Failures should be investigated to guarantee this backport complies with the Quality standards.Ping your team's associated Software Engineer in Test (SET) to confirm the failures are unrelated to the merge request. If there's no SET assigned, ask for assistance on the
#test-platform
Slack channel. -
- Resolved by Sofia Vistas
@eduardosanz Thee2e:package-and-test-ee
job has failed.-
e2e:package-and-test-ee
pipeline: https://gitlab.com/gitlab-org/gitlab/-/pipelines/1375983350
e2e:package-and-test-ee
pipeline is allowed to fail due its flakiness. Failures should be investigated to guarantee this backport complies with the Quality standards.Ping your team's associated Software Engineer in Test (SET) to confirm the failures are unrelated to the merge request. If there's no SET assigned, ask for assistance on the
#test-platform
Slack channel. -
requested review from @ifarkas
removed review request for @ifarkas