Skip to content

Filter out system notes referencing inaccessible work items

What does this MR do and why?

Filter out system notes referencing inaccessible work items

Usually if there are system notes that reference an item that cannot be accessed by the user we filter out that system note altogether.

This was not happening for system notes about adding or removing a child work item or a parent work item.

re https://gitlab.com/gitlab-org/gitlab/-/issues/471981

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Adding the screenshots from the fix here in the meantime, so that I can then copy these over to the MR itself:

Page Member Anonymous(before) Anonymous(after)
public issue linking to an epic in a public group(/-/issues page) Screenshot_2024-07-12_at_12.19.50 Screenshot 2024-07-12 at 14.51.55.png Screenshot_2024-07-12_at_12.20.25
same issue as above( /-/work_items page) Screenshot_2024-07-12_at_12.21.13 Screenshot 2024-07-12 at 15.11.12.png Screenshot_2024-07-12_at_12.21.37
public epic that was linked to the issue above(/-/epics page) Screenshot_2024-07-12_at_12.23.58 Screenshot 2024-07-12 at 15.12.38.png Screenshot_2024-07-12_at_12.24.22
same epic as above(/-/work_items page) Screenshot_2024-07-12_at_12.25.30 Screenshot 2024-07-12 at 15.13.26.png Screenshot_2024-07-12_at_12.26.28
public issue linking to an epic in a private group(/-/issues page) Jul-12-2024_13-04-54 Jul-12-2024 15-14-52.gif Jul-12-2024_13-02-59
public issue linking to an epic in a private group(/-/work_items page) Jul-12-2024_13-02-02 Jul-12-2024 15-15-55.gif Jul-12-2024_13-05-53

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Alexandru Croitor

Merge request reports