Refactor CI ProjectConfig sources to use static precedence
What does this MR do and why?
This change refactors sources for ProjectConfig
to use a static list of sources instead of manipulating it in EE to make the precedence of sources clearer.
EE-only configs return nil
for CE.
The MR seems quite big, but it's mostly just moving existing code around.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Related to #466430 (closed)
Merge request reports
Activity
assigned to @mcavoj
added pipelinetier-1 label
added 1 commit
- 943f3238 - Refactor CI ProjectConfig sources to use static precedence
- Resolved by Martin Čavoj
2 Warnings This merge request is quite big (972 lines changed), please consider splitting it into multiple merge requests. The master pipeline status page reported failures in If these jobs fail in your merge request with the same errors, then they are not caused by your changes.
Please check for any on-going incidents in the incident issue tracker or in the#master-broken
Slack channel.Reviewer roulette
Category Reviewer Maintainer backend @atiwari71
(UTC+5.5, 2.5 hours ahead of author)
@felipe_artur
(UTC-3, 6 hours behind author)
~"Verify" Reviewer review is optional for ~"Verify" @ayufan
(UTC+2, 1 hour behind author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Userchanged milestone to %17.3
added 1 commit
- 8f388fa3 - Use let_it_be for compliance project creation
- Resolved by Fabio Pitino
added 1 commit
- 8e266661 - Refactor CI ProjectConfig sources to use static precedence
- Resolved by Fabio Pitino
Hi @furkanayhan, this MR addresses Fabio's suggestion here. Would you have time to review it?
The MR seems quite big but it's mostly just moving existing code around. If you prefer to split it up, I could move each config separately which could simplify the reviews.
requested review from @furkanayhan
mentioned in issue #471726 (closed)
removed review request for @furkanayhan
requested review from @Andyschoenen
requested review from @fabiopitino and removed review request for @Andyschoenen