Skip to content
Snippets Groups Projects

Refactor CI ProjectConfig sources to use static precedence

What does this MR do and why?

This change refactors sources for ProjectConfig to use a static list of sources instead of manipulating it in EE to make the precedence of sources clearer.

EE-only configs return nil for CE.

The MR seems quite big, but it's mostly just moving existing code around.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #466430 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • 2 Warnings
    :warning: This merge request is quite big (972 lines changed), please consider splitting it into multiple merge requests.
    :warning: The master pipeline status page reported failures in

    If these jobs fail in your merge request with the same errors, then they are not caused by your changes.
    Please check for any on-going incidents in the incident issue tracker or in the #master-broken Slack channel.

    Reviewer roulette

    Category Reviewer Maintainer
    backend @atiwari71 profile link current availability (UTC+5.5, 2.5 hours ahead of author) @felipe_artur profile link current availability (UTC-3, 6 hours behind author)
    ~"Verify" Reviewer review is optional for ~"Verify" @ayufan profile link current availability (UTC+2, 1 hour behind author)

    Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

    Edited by Ghost User
  • Martin Čavoj changed milestone to %17.3

    changed milestone to %17.3

  • Martin Čavoj added 1 commit

    added 1 commit

    • 8f388fa3 - Use let_it_be for compliance project creation

    Compare with previous version

  • Martin Čavoj resolved all threads

    resolved all threads

  • Martin Čavoj
  • Martin Čavoj added 1 commit

    added 1 commit

    • 8e266661 - Refactor CI ProjectConfig sources to use static precedence

    Compare with previous version

    • Resolved by Fabio Pitino

      Hi @furkanayhan, this MR addresses Fabio's suggestion here. Would you have time to review it?

      The MR seems quite big but it's mostly just moving existing code around. If you prefer to split it up, I could move each config separately which could simplify the reviews.

  • Martin Čavoj requested review from @furkanayhan

    requested review from @furkanayhan

  • mentioned in issue #471726 (closed)

  • Furkan Ayhan removed review request for @furkanayhan

    removed review request for @furkanayhan

  • requested review from @Andyschoenen

  • Andy Schoenen approved this merge request

    approved this merge request

  • Andy Schoenen requested review from @fabiopitino and removed review request for @Andyschoenen

    requested review from @fabiopitino and removed review request for @Andyschoenen

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading