Compile CSS custom properties to hex values in mailers stylesheets
What does this MR do and why?
Compile CSS custom properties to hex values in mailers stylesheets
- Add PostCSS plugins
- Move mailer stylesheets to
mailers/
directory - Update import paths
- Remove asset precompile rules, use wildcard
- Add mailers processor to CSS compile script
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots or screen recordings
What | After |
---|---|
/rails/mailers/notify/pipeline_failed_email |
![]() |
/rails/mailers/license_mailer/approaching_active_user_count_limit.html |
![]() |
How to set up and validate locally
Validate CSS
- Run
yarn build:css --watch
- Have a look at e.g.
app/assets/builds/mailers/notify_enhanced.css
. A lot of custom properties should now be inlined (if not, all)
Validate email styles
- Remove pre-compiled CSS assets:
rm app/assets/builds/**/*.css
- Navigate to the pages above
- Write a comment which mentiones a few labels.
- Go to
/rails/letter_opener
. Wait until the notification email "comes through"
Merge request reports
Activity
changed milestone to %17.2
assigned to @sdejonge
removed dark mode label
removed workflowstart label
- Resolved by Paul Gascou-Vaillancourt
@leipert could you please review? Thanks!
requested review from @leipert
added pipelinetier-1 label
- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@sdejonge
- please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
mentioned in merge request !158838 (merged)
2 Warnings The master pipeline status page reported failures in If these jobs fail in your merge request with the same errors, then they are not caused by your changes.
Please check for any on-going incidents in the incident issue tracker or in the#master-broken
Slack channel.You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @arpitgogia
(UTC+5.5, 4.5 hours behind author)
@kerrizor
(UTC-7, 17 hours behind author)
frontend @rcrespo3
(UTC-4, 14 hours behind author)
@kushalpandya
(UTC-4, 14 hours behind author)
~"Tooling" Reviewer review is optional for ~"Tooling" @psjakubowska
(UTC+2, 8 hours behind author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Useradded typemaintenance label
mentioned in merge request !158909 (merged)
- Resolved by Lukas Eipert
- Resolved by Lukas Eipert
- Resolved by Lukas Eipert
- Resolved by Lukas Eipert