Skip to content
Snippets Groups Projects

Drop migration that finalizes migration to add PAT expiration

Merged Stan Hu requested to merge sh-drop-token-expiration-migrations-17-0 into 17-0-stable-ee

What does this MR do and why?

This MR drops the migration that finalizes a migration that added an expiration to all tokens that did not have one. Due to the impact on users, this drops the migration to avoid interruption to user workflows without them realizing it.

Note this only will help customers that have not already upgraded to GitLab 16.0. This finalize step will already be run for instances that have already upgraded to GitLab 16.7.

Related to https://gitlab.com/gitlab-org/gitlab/-/issues/462157

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
  • The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes).
  • This MR has a severity label assigned (if applicable).
  • Set the milestone of the merge request to match the target backport branch version.
  • This MR has been approved by a maintainer (only one approval is required).
  • Ensure the e2e:package-and-test-ee job has either succeeded or been approved by a Software Engineer in Test.

Note to the merge request author and maintainer

If you have questions about the patch release process, please:

Edited by Imre Farkas

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Resolved by Adil Farrukh

      :warning: @stanhu The e2e:package-and-test-ee job has failed.

      e2e:package-and-test-ee pipeline is allowed to fail due its flakiness. Failures should be investigated to guarantee this backport complies with the Quality standards.

      Ping your team's associated Software Engineer in Test (SET) to confirm the failures are unrelated to the merge request. If there's no SET assigned, ask for assistance on the #test-platform Slack channel.

  • Stan Hu added 3 commits

    added 3 commits

    Compare with previous version

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-package-and-test: :x: test report for 37c49eb8

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Govern      | 278    | 8      | 13      | 3     | 299   | ❌     |
    | Create      | 211    | 86     | 31      | 44    | 328   | ❌     |
    | Verify      | 4      | 1      | 0       | 0     | 5     | ❌     |
    | Plan        | 15     | 7      | 2       | 0     | 24    | ❌     |
    | Monitor     | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Data Stores | 5      | 6      | 0       | 0     | 11    | ❌     |
    | Package     | 0      | 3      | 4       | 0     | 7     | ❌     |
    | Release     | 1      | 0      | 0       | 0     | 1     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 518    | 111    | 50      | 47    | 679   | ❌     |
    +-------------+--------+--------+---------+-------+-------+--------+
    • Resolved by Sofia Vistas

      :warning: @stanhu The e2e:package-and-test-ee job has failed.

      e2e:package-and-test-ee pipeline is allowed to fail due its flakiness. Failures should be investigated to guarantee this backport complies with the Quality standards.

      Ping your team's associated Software Engineer in Test (SET) to confirm the failures are unrelated to the merge request. If there's no SET assigned, ask for assistance on the #test-platform Slack channel.

  • Imre Farkas requested review from @sgarg_gitlab and @a_akgun

    requested review from @sgarg_gitlab and @a_akgun

  • Imre Farkas approved this merge request

    approved this merge request

    • Resolved by Sofia Vistas

      :wave: @ifarkas, thanks for approving this merge request.

      This is the first time the merge request has been approved. Please ensure the e2e:package-and-test-ee job has succeeded. If there is a failure, a Software Engineer in Test (SET) needs to confirm the failures are unrelated to the merge request. If there's no SET assigned to this team, ask for assistance on the #test-platform Slack channel.

  • Please register or sign in to reply
    Loading