Drop migration that finalizes migration to add PAT expiration
What does this MR do and why?
This MR drops the migration that finalizes a migration that added an expiration to all tokens that did not have one. Due to the impact on users, this drops the migration to avoid interruption to user workflows without them realizing it.
Note this only will help customers that have not already upgraded to GitLab 16.0. This finalize step will already be run for instances that have already upgraded to GitLab 16.7.
Related to https://gitlab.com/gitlab-org/gitlab/-/issues/462157
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch. -
The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes). -
This MR has a severity label assigned (if applicable). -
Set the milestone of the merge request to match the target backport branch version. -
This MR has been approved by a maintainer (only one approval is required). -
Ensure the e2e:package-and-test-ee
job has either succeeded or been approved by a Software Engineer in Test.
Note to the merge request author and maintainer
If you have questions about the patch release process, please:
- Refer to the patch release runbook for engineers and maintainers for guidance.
- Ask questions on the
#releases
Slack channel (internal only).
Merge request reports
Activity
assigned to @stanhu
added devopsgovern groupauthentication sectionsec labels
- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@stanhu
- please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
3 Warnings You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Backporting to older releases requires an exception request process The e2e:package-and-test-ee
job needs to succeed or have approval from a Software Engineer in Test.
Read the "QA e2e:package-and-test-ee" section for more details.1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @pslaughter
(UTC-5, 2 hours ahead of author)
@brytannia
(UTC+2, 9 hours ahead of author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
QA
e2e:package-and-test-ee
@stanhu, the
package-and-test
job must complete before merging this merge request.*If there are failures on the
package-and-test
pipeline, ping your team's associated Software Engineer in Test (SET) to confirm the failures are unrelated to the merge request. If there's no SET assigned, ask for assistance on the#test-platform
Slack channel.If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 6 commits
-
0b1f7fe8...6a882032 - 4 commits from branch
17-0-stable-ee
- 54a1caeb - No-op CleanupPersonalAccessTokensWithNilExpiresAt migration
- ab4117ca - NOP migration that finalizes migration to add PAT expiration
-
0b1f7fe8...6a882032 - 4 commits from branch
requested review from @ifarkas
- Resolved by Adil Farrukh
@ifarkas What do you think of this approach for 16.7 - 17.0?
mentioned in merge request !153468 (merged)
- Resolved by Adil Farrukh
- Resolved by Adil Farrukh
@stanhu Thee2e:package-and-test-ee
job has failed.-
e2e:package-and-test-ee
pipeline: https://gitlab.com/gitlab-org/gitlab/-/pipelines/1365844991
e2e:package-and-test-ee
pipeline is allowed to fail due its flakiness. Failures should be investigated to guarantee this backport complies with the Quality standards.Ping your team's associated Software Engineer in Test (SET) to confirm the failures are unrelated to the merge request. If there's no SET assigned, ask for assistance on the
#test-platform
Slack channel. -
added 3 commits
-
ab4117ca...e76921dd - 2 commits from branch
17-0-stable-ee
- 37c49eb8 - No-op CleanupPersonalAccessTokensWithNilExpiresAt migration
-
ab4117ca...e76921dd - 2 commits from branch
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-package-and-test:
test report for 37c49eb8expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 278 | 8 | 13 | 3 | 299 | ❌ | | Create | 211 | 86 | 31 | 44 | 328 | ❌ | | Verify | 4 | 1 | 0 | 0 | 5 | ❌ | | Plan | 15 | 7 | 2 | 0 | 24 | ❌ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Data Stores | 5 | 6 | 0 | 0 | 11 | ❌ | | Package | 0 | 3 | 4 | 0 | 7 | ❌ | | Release | 1 | 0 | 0 | 0 | 1 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 518 | 111 | 50 | 47 | 679 | ❌ | +-------------+--------+--------+---------+-------+-------+--------+
- Resolved by Sofia Vistas
@stanhu Thee2e:package-and-test-ee
job has failed.-
e2e:package-and-test-ee
pipeline: https://gitlab.com/gitlab-org/gitlab/-/pipelines/1367189781
e2e:package-and-test-ee
pipeline is allowed to fail due its flakiness. Failures should be investigated to guarantee this backport complies with the Quality standards.Ping your team's associated Software Engineer in Test (SET) to confirm the failures are unrelated to the merge request. If there's no SET assigned, ask for assistance on the
#test-platform
Slack channel. -
requested review from @sgarg_gitlab and @a_akgun
- Resolved by Sofia Vistas
@ifarkas
, thanks for approving this merge request.This is the first time the merge request has been approved. Please ensure the
e2e:package-and-test-ee
job has succeeded. If there is a failure, a Software Engineer in Test (SET) needs to confirm the failures are unrelated to the merge request. If there's no SET assigned to this team, ask for assistance on the#test-platform
Slack channel.