Add ADR for OpenBao AppRole auth method
Related to #467150 (comment 1966244253)
This adds an ADR to the secrets manager blueprint regarding the use of AppRole auth method.
Merge request reports
Activity
assigned to @iamricecake
added devopsgovern grouppipeline security sectionsec labels
- Resolved by Erick Bajao
@fabiopitino can you please take a look?
requested review from @fabiopitino
- A deleted user
added Architecture Evolution Blueprint documentation labels
1 Warning ⚠ This merge request does not refer to an existing milestone. 2 Messages 📖 This merge request might require a review from a Coach Engineer. 📖 This MR contains docs in the /doc/architecture directory, but any Maintainer (other than the author) can merge. You do not need tech writer review. Architecture Evolution Review
❗ We plan to move the architecture and design documents to the public GitLab handbook. This will change how you contribute to the documents. Follow the migration issue and join the#architecture
and#handbook
Slack channels for updates.This merge request might require a review from a Coach Engineer.
The following files, which might require the additional review, have been changed:
doc/architecture/blueprints/secret_manager/decisions/006_approle_authentication_rails.md
doc/architecture/blueprints/secret_manager/index.md
If needed, you can retry the
🔁 danger-review
job that generated this comment.Generated by
🚫 DangerEdited by Ghost Useradded docs-only label
- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
👋 @iamricecake
- please see the following guidance and update this merge request.1 Error ❌ Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
added typemaintenance label
mentioned in issue #467150 (closed)
Hello everyone
👋 we plan to move architecture design documents (formerly known as blueprints) from thegitlab
project (docs page) to the public handbook.We already did some prep work and will start migrating design docs with the status
rejected
andimplemented
(this week and/or beginning next week). After that, we'll continue migrating the remaining documents over to the public handbook.Please follow this issue for updates on the timeline and additional migration info. We'll also keep you up to date in the
#architecture
(#engineering-fyi
) and#handbook
Slack channels and post comments on MRs with the Architecture Evolution Blueprint label.To make this migration as smooth as possible for everyone, here's what you can do:
- For smaller pending changes, try to merge soon so we can migrate the content for you
🤝 - If you're working on the first iteration of your design doc or on bigger changes, we'll inform you on the MR again about the timeline for the migration.
- If you're close to merging the first iteration, please do so. We can migrate the doc for you then!
- If you need more time to finish the first iteration, consider one of the following:
- Finish all discussions in the current MR, then close that MR and open a new MR in the handbook with the final version. Ask your coach for a final review and merge.
- Abort the discussion and close the MR. Open a new MR in the handbook and start the discussion again (maybe copy summaries to the new MR)
- Location for new design documents will be
content/handbook/engineering/architecture/design-documents/
. You'll need to change a few things in your docs. See this MR for the first doc migration as an orientation. We'll publish a checklist for you and let you know on the MR in a follow-up.
There's no action required today. This comment is just to let you know about this change and showcase options.
Have a great day
☀ you all rock🎸 - For smaller pending changes, try to merge soon so we can migrate the content for you
added design documents migrationimpacted label
added design documents migration impactexisting label and removed design documents migration impactnew label
added design document statusproposed label
- Resolved by Marc Saleiko
@iamricecake we're migrating architecture design documents (formerly known as blueprints) from the
gitlab
project (docs page) to the public handbook.The new handbook page already exists and we want to migrate
proposed
,accepted
, andongoing
content this week. We identified that this MR changes content of existing design documents, so we kindly ask you to merge this as soon as possible. More info on how to contribute to design docs in the new location will follow shortly.🤞 We'll start migrating design docs of the above-mentioned statuses on Tue 24-07-09 and we'll pick the oldest ones first. (see internal Slack message and updates on migration issue)
❗ Action required: Please comment with one of the following:-
Merge before EOD Wed 24-07-10 (EOD means we won't start migrating the affected design doc before 24-07-11)
@msaleiko I'm committed to merging this MR before EOD Wed 24-07-10 so migrate the content for me to the handbook.
-
@msaleiko don't migrate this content for us. I'll take care of raising a new MR in the handbook project for this change after the migration.
Thanks a lot for your help
🙂 -