Update tools injector image
Issue: Extract tools-injector from gitlab-web-ide-vsco... (#441427 - closed)
What does this MR do and why?
With the version 1.0.0 release of the gitlab-workspaces-tools, we can now replace the tools-injector image to use the one built by the new repo. The reason behind this is to decouple the tools injector from the web-ide-vs-code-fork.
MR acceptance checklist
-
Workspaces can be created with the new image with no errors/regression in behaviour
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
old_tools_image | new_tools_image |
How to set up and validate locally
- Setup GDK
- Ensure the current GitLab branch is this MR's branch
- setup remote-development locally and create a workspace
Numbered steps to set up and validate the change are strongly suggested.
Merge request reports
Activity
assigned to @Saahmed
added pipelinetier-1 label
changed milestone to %17.2
- A deleted user
added backend label
2 Warnings a788abb4: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. f18048ea: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. Reviewer roulette
Category Reviewer Maintainer backend @tyleramos
(UTC-4)
@avielle
(UTC+2)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Usermentioned in issue #441427 (closed)
- Resolved by Enrique Alcántara
Hello! @ealcantara
the previous imageregistry.gitlab.com/gitlab-org/gitlab-web-ide-vscode-fork/web-ide-injector:9
appears to have been using vscode"version": "1.85.2"
. The updated image usesversion 1.89.1-1.0.0-dev-20240612072203
of the fork as explained in the release notes.Is it safe to bump the version in this MR or is there a release/testing/validation process I would need to complete that I have missed somewhere? LMK your thoughts, thank you!
requested review from @vtak and @ealcantara
mentioned in merge request gitlab-web-ide-vscode-fork!84 (merged)
- Resolved by Enrique Alcántara
@Saahmed - Our docs mention the minimum GLIBC version(2.28) we support for our VS Code fork. So I tested it with an image with has this glibc version and it is working. I verified the pod logs and nothing unusual over there.
LGTM!
@ealcantara - Can you merge this?
Edited by Vishal Tak
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label