Update tools injector image

added Category:Remote Development devopscreate groupide sectiondev typefeature workflowin dev rd-workflowprioritized labels

assigned to @Saahmed

added pipelinetier-1 label

changed milestone to %17.2

added backend label

	2 Warnings
	a788abb4: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines.
	f18048ea: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines.

Reviewer roulette

Category	Reviewer	Maintainer
backend	`@tyleramos` (UTC-4)	`@avielle` (UTC+2)

Please check reviewer's status!

Reviewer is available!
Reviewer is unavailable!

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

changed title from Draft: update tools injector image to Draft: Update tools injector image

changed the description

mentioned in issue #441427 (closed)

marked the checklist item Workspaces can be created with the new image with no errors/regression in behaviour as completed

Hello! @ealcantara the previous image registry.gitlab.com/gitlab-org/gitlab-web-ide-vscode-fork/web-ide-injector:9 appears to have been using vscode "version": "1.85.2". The updated image uses version 1.89.1-1.0.0-dev-20240612072203 of the fork as explained in the release notes.

Is it safe to bump the version in this MR or is there a release/testing/validation process I would need to complete that I have missed somewhere? LMK your thoughts, thank you!

requested review from @vtak and @ealcantara

marked this merge request as ready

Looking now

mentioned in merge request gitlab-web-ide-vscode-fork!84 (merged)

approved this merge request

@Saahmed - Our docs mention the minimum GLIBC version(2.28) we support for our VS Code fork. So I tested it with an image with has this glibc version and it is working. I verified the pod logs and nothing unusual over there.

LGTM!

@ealcantara - Can you merge this?

added pipeline:mr-approved label

added pipelinetier-2 label and removed pipelinetier-1 label

Before you set this MR to auto-merge

This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

Before you resolve this discussion, please check the following:

You are the last maintainer of this merge request
The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
This pipeline is recent enough (created in the last 8 hours)

If all the criteria above apply, please resolve this discussion and the set auto-merge for this merge request.

See pipeline tiers and merging a merge request for more details.

E2E Test Result Summary

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for a788abb4

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Create      | 125    | 0      | 11      | 0     | 136   | ✅     |
| Plan        | 60     | 0      | 2       | 0     | 62    | ✅     |
| Govern      | 65     | 0      | 0       | 0     | 65    | ✅     |
| Verify      | 36     | 0      | 2       | 0     | 38    | ✅     |
| Package     | 19     | 0      | 12      | 0     | 31    | ✅     |
| Data Stores | 31     | 0      | 0       | 0     | 31    | ✅     |
| Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
| Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
| Fulfillment | 1      | 0      | 0       | 0     | 1     | ✅     |
| Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
| Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 352    | 0      | 28      | 0     | 380   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

e2e-package-and-test: test report for a788abb4

expand test summary

+-------------------------------------------------------------+
|                       suites summary                        |
+--------+--------+--------+---------+-------+-------+--------+
|        | passed | failed | skipped | flaky | total | result |
+--------+--------+--------+---------+-------+-------+--------+
| Create | 364    | 63     | 45      | 0     | 472   | ❌     |
| Govern | 4      | 0      | 0       | 0     | 4     | ✅     |
| Plan   | 8      | 0      | 0       | 0     | 8     | ✅     |
+--------+--------+--------+---------+-------+-------+--------+
| Total  | 376    | 63     | 45      | 0     | 484   | ❌     |
+--------+--------+--------+---------+-------+-------+--------+

e2e-test-on-cng: test report for a788abb4

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Create      | 139    | 0      | 15      | 0     | 154   | ✅     |
| Plan        | 79     | 0      | 11      | 0     | 90    | ✅     |
| Data Stores | 34     | 0      | 9       | 0     | 43    | ✅     |
| Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
| Package     | 23     | 0      | 15      | 0     | 38    | ✅     |
| Verify      | 53     | 0      | 13      | 0     | 66    | ✅     |
| Manage      | 2      | 0      | 8       | 0     | 10    | ✅     |
| Govern      | 77     | 0      | 9       | 0     | 86    | ✅     |
| Secure      | 3      | 0      | 2       | 0     | 5     | ✅     |
| Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
| Fulfillment | 2      | 0      | 24      | 0     | 26    | ✅     |
| Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
| ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
| Ai-powered  | 0      | 0      | 1       | 0     | 1     | ➖     |
| Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
| Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 427    | 0      | 126     | 0     | 553   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

approved this merge request

added pipelinetier-3 label and removed pipelinetier-2 label

resolved all threads

enabled automatic add to merge train when the pipeline for 0780d58e succeeds

resolved all threads

@Saahmed FYI: The CI pipeline fails because we have to update unit tests with the new image registry URI. You can see the test failure in https://gitlab.com/gitlab-org/gitlab/-/jobs/7168530430

aborted automatic add to merge train because source branch was updated

added 2 commits

f8d7a5d8 - update image name to fix tests
c2e2dae1 - replace references to old tools image with new image

Compare with previous version

reset approvals from @ealcantara and @vtak by pushing to the branch

Generated by gitlab_quality-test_tooling.

Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.

Click to expand

Job	File	Name	Duration	Expected duration
#7180292099	`spec/lib/search/settings_spec.rb#L6`	Search results for settings behaves like all sections exist and have correct anchor links has only valid settings sections	46.73 s	< 27.12 s
#7180292632	`ee/spec/lib/ee/search/settings_spec.rb#L19`	Search results for settings behaves like all sections exist and have correct anchor links has only valid settings sections	48.28 s	< 27.12 s
#7183508678	`ee/spec/lib/ee/search/settings_spec.rb#L19`	Search results for settings behaves like all sections exist and have correct anchor links has only valid settings sections	51.04 s	< 27.12 s

added rspec:slow test detected label

@ealcantara @vtak Approvals got reset, would need a second go at this please .

approved this merge request

resolved all threads

question @Saahmed given that this MR upgrades the version of VSCode that Workspaces, we could consider it as introducing user-facing changes. Should we add a changelog entry and mark the main commit with EE: true ?

See