Ability to check for duo pro bulk assignment in SM instances
What does this MR do and why?
Resolves: https://gitlab.com/gitlab-org/gitlab/-/issues/443568
We begin to implement bulk users assignment ability for Duo Pro in Self managed instances. Epic: https://gitlab.com/groups/gitlab-org/-/epics/12959. This is very similar to the work that has already been implemented for Gitlab.com through this epic: &11463 (closed)
As a starting step for frontend, this MR creates a new feature flag sm_duo_pro_bulk_user_assignment
to allow/disallow admin to bulk assign users from the Admin page on SM instance. An adjustment has also been made to the helper method duo_pro_bulk_user_assignment_available
which checks for feature flag option based on the instance being Saas or self managed.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
No frontend changes.
How to set up and validate locally
No functionality has been changed. Nothing to manually test, and the feature flags exposure itself is covered with automated tests
Related to #443568
Merge request reports
Activity
changed milestone to %Next 1-3 releases
assigned to @div.ya
added pipelinetier-1 label
- A deleted user
added backend label
1 Warning featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @bauerdominic
(UTC+2, same timezone as author)
@jprovaznik
(UTC+2, same timezone as author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerQuarantined Fulfillment QA E2E Tests
The following Fulfillment QA E2E tests are in quarantine. If your changes would be covered by these tests, please be sure to perform manual testing.
Description Location Fulfillment with existing compute minutes packs behaves like Purchase storage adds additional storage to group namespace ./qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_storage_spec.rb[1:3:1:1] Fulfillment with an active subscription behaves like Purchase storage adds additional storage to group namespace ./qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_storage_spec.rb[1:2:1:1] Fulfillment without active subscription behaves like Purchase storage adds additional storage to group namespace ./qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_storage_spec.rb[1:1:1:1] Fulfillment Utilization in usage quotas storage tab for free plan with a project shows correct used up storage for namespace ./qa/specs/features/ee/browser_ui/11_fulfillment/utilization/free_namespace_storage_spec.rb[1:1:1:1] Fulfillment Utilization when namespace storage usage goes back down below the limit reverts the namespace back to full-access mode ./qa/specs/features/ee/browser_ui/11_fulfillment/utilization/namespace_storage_limit_spec.rb[1:1:2:1] Fulfillment Utilization when namespace storage usage hits the limit puts the namespace into read-only mode ./qa/specs/features/ee/browser_ui/11_fulfillment/utilization/namespace_storage_limit_spec.rb[1:1:1:1] changed milestone to %17.2
requested review from @shreyasagarwal
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
- Resolved by Jarka Košanová
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you resolve this discussion, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please resolve this discussion and the set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
- Resolved by Jarka Košanová
@jarka Could you please take over as the maintainer for the MR?
requested review from @jarka and removed review request for @shreyasagarwal
added 1 commit
- 2b2f39ec - Ability to check for SM duo pro bulk assignment
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 2b2f39ecexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 56 | 0 | 2 | 0 | 58 | ✅ | | Create | 121 | 0 | 11 | 0 | 132 | ✅ | | Verify | 30 | 0 | 2 | 0 | 32 | ✅ | | Govern | 65 | 0 | 0 | 0 | 65 | ✅ | | Package | 19 | 0 | 12 | 0 | 31 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Data Stores | 31 | 0 | 0 | 0 | 31 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 339 | 0 | 28 | 0 | 367 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 2b2f39ecexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Fulfillment | 4 | 0 | 48 | 0 | 52 | ✅ | | Create | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 14 | 0 | 48 | 0 | 62 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for 2b2f39ecexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 79 | 0 | 6 | 0 | 85 | ✅ | | Verify | 55 | 0 | 11 | 0 | 66 | ✅ | | Create | 135 | 0 | 15 | 0 | 150 | ✅ | | Ai-powered | 0 | 0 | 1 | 0 | 1 | ➖ | | Govern | 77 | 0 | 9 | 0 | 86 | ✅ | | Data Stores | 34 | 0 | 9 | 0 | 43 | ✅ | | Secure | 3 | 0 | 1 | 0 | 4 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Manage | 2 | 0 | 8 | 0 | 10 | ✅ | | Package | 23 | 0 | 15 | 0 | 38 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Fulfillment | 2 | 0 | 24 | 0 | 26 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 425 | 0 | 118 | 0 | 543 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
added pipelinetier-3 label and removed pipelinetier-2 label
enabled automatic add to merge train when the pipeline for 9c9f15f2 succeeds
mentioned in commit cf2a4f3c
mentioned in merge request !156824 (merged)
added self-managed workflowstaging-canary labels and removed self-managed label
@div.ya This merge request was deployed to the workflowstaging-canary environment. You may want to enable the associated feature flag on this environment with/chatops run feature set sm_duo_pro_bulk_user_assignment true --staging
.This message was generated automatically. You're welcome to improve it.
This merge request was deployed to the workflowcanary environment. You may want to enable the associated feature flag on this environment with/chatops run feature set sm_duo_pro_bulk_user_assignment true --production
.This message was generated automatically. You're welcome to improve it.
This merge request was deployed to the workflowstaging environment. You may want to enable the associated feature flag on this environment with/chatops run feature set sm_duo_pro_bulk_user_assignment true --staging
.This message was generated automatically. You're welcome to improve it.
This merge request was deployed to the workflowproduction environment. You may want to enable the associated feature flag on this environment with/chatops run feature set sm_duo_pro_bulk_user_assignment true --production
.This message was generated automatically. You're welcome to improve it.
added workflowcanary label and removed workflowstaging-canary label
added self-managed workflowstaging labels and removed self-managed workflowcanary labels
added self-managed workflowproduction labels and removed self-managed workflowstaging labels
added workflowpost-deploy-db-staging label and removed workflowproduction label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label