Show dependency location count if `occurrenceCount` field is present
What does this MR do and why?
Related #467085 (closed)
Show dependency location count if occurrenceCount
field is present, even it's it only 1 location, instead of the path.
We're doing this because (see related issue)
It's not possible to get both the project / location path and the counts in a performant manner, so we've decided to always show the counts even if there is only 1.
This follows Always show project count for group dependency ... (!156200 - merged) • Lorenz van Herwaarden • 17.2 which made a similar change for the project column.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Create a new group
- Import https://gitlab.com/gitlab-examples/security/security-reports project in this new group
- Import https://gitlab.com/lorenzvanherwaarden/security-reports-with-few-dependencies/ project in this new group (same as project above but with less dependencies)
- Run a pipeline on both projects
- Go to
http://gdk.test:3000/groups/<your-group-name>/-/dependencies
- Scroll through dependencies and check the Location column. It should contain rows with _2 locations and 1 location. For both, when you click a dropdown should appear with the list of the location(s) where these dependencies appear.
Merge request reports
Activity
changed milestone to %17.2
assigned to @lorenzvanherwaarden
added pipelinetier-1 label
Reviewer roulette
Category Reviewer Maintainer frontend @dzubova
(UTC+2, same timezone as author)
@vitallium
(UTC+2, same timezone as author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
🔁 danger-review
job that generated this comment.Generated by
🚫 DangerEdited by Ghost Useradded 131 commits
-
fc160007...3a14b8c6 - 130 commits from branch
master
- 549838f8 - Merge branch 'master' into 'dependency-list/prefer-location-count-to-path'
-
fc160007...3a14b8c6 - 130 commits from branch
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 15a00a1b and 3acc9482
✨ Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.36 MB 4.36 MB - 0.0 % mainChunk 3.32 MB 3.32 MB - 0.0 %
Note: We do not have exact data for 15a00a1b. So we have used data from: ad5cf40c.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
🚫 DangerEdited by Ghost Usermentioned in epic &12371 (closed)
removed workflowin dev label
- Resolved by Samantha Ming
@dpisek could you do the initial review? It's similar to Always show project count for group dependency ... (!156200 - merged) • Lorenz van Herwaarden • 17.2.
We chose not to remove the location path display, because it's used on both the project and organization dependency list, where we do not have the
occurrenceCount
, see #467085 (comment 1947497281).So the change is to always shows the location count and dropdown if there is an
occurrenceCount
.
requested review from @dpisek
mentioned in issue #467085 (closed)
- Resolved by Lorenz van Herwaarden