Skip to content

Add missing ResourceLinkEvent#synthetic_note_class

Kassio Borges requested to merge kassio/add-missing-synthetic_note_class-to-ResourceLinkEvent into master

What does this MR do and why?

Add missing ResourceLinkEvent#synthetic_note_class. In the case of the ResourceLinkEvent we do not need a new note, so to avoid the NoMethodError, we decided to make the note optional by the returning false on #synthetic_note_class.

This also adds tests to ensure new classes that inherits from ResourceEvent implements this method to avoid problems.

Related to:

Changelog: fixed

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Kassio Borges

Merge request reports