Skip to content

GraphQL: Check jobsStatistics permission in group

Pedro Pombeiro (OOO from July 16th till Aug 7th) requested to merge pedropombeiro/424790/handle-group-resolver-permissions into master

What does this MR do and why?

In %17.1, we're adding the Group runners dashboard. In this sense, we need to adapt jobsStatistics to check for the :read_jobs_statistics permission in the parent group, if that's our context. Note: It is important to get this MR into %17.1, otherwise group maintainers will not see the page populated with the expected stats.

EE: true

Part of #424790 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Scenario Admin Owner Maintainer
master image image image
this branch image image image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Ensure you have an Ultimate license on your GDK
  2. Go to the shell in your GDK gitlab directory and run bundle exec rake "gitlab:seed:runner_fleet". This will seed your GDK with some runners and jobs required for testing this MR.
  3. Go to http://gdk.test:3000/groups/rf-top-level-group-1/-/group_members and invite a user to the project as a maintainer
  4. Impersonate that user
  5. Visit http://gdk.test:3000/groups/rf-top-level-group-1/-/runners/dashboard

The Wait time to pick a job section should be populated in this branch, and not in master.

Edited by Pedro Pombeiro (OOO from July 16th till Aug 7th)

Merge request reports