Render environments as labels in Secrets table
What does this MR do and why?
Follow-up from !154536 (merged).
Because we changed the mock data in !154536 (merged), scoped labels (which are the same as environments, making this data redundant) are no longer shown. This MR fixes that so we render environments as scoped labels in the Secrets table.
Note that there's no backend integration for the Secrets Manager yet, so we're just working with mock data for now.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Enable the
ci_tanukey_ui
feature flag for your project.Feature.enable(:ci_tanukey_ui, <project>)
- Visit
<path-to-project>/-/secrets
.
Merge request reports
Activity
assigned to @mgandres
changed milestone to %17.1
added pipelinetier-1 label
added frontend sectionci labels and removed pipelinetier-1 label
added pipelinetier-1 label
added 11 commits
-
c68c4cfa...3b32adfc - 10 commits from branch
master
- 74c1175a - Render environments as labels in Secrets table
-
c68c4cfa...3b32adfc - 10 commits from branch
added devopsverify grouppipeline security typemaintenance labels
added feature flagexists label
mentioned in merge request !154536 (merged)
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer frontend @eduardobonet
(UTC+2, 6 hours behind author)
@iamphill
(UTC+1, 7 hours behind author)
~"Verify" Reviewer review is optional for ~"Verify" @mfluharty
(UTC-6, 14 hours behind author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Usermentioned in issue #424460 (closed)
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits fca17173 and 5377e7b2
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.36 MB 4.36 MB - 0.0 % mainChunk 3.32 MB 3.32 MB - 0.0 %
Note: We do not have exact data for fca17173. So we have used data from: 85c5faa4.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by Ghost Useradded 2461 commits
-
74c1175a...5e26f833 - 2460 commits from branch
master
- 29b2bf33 - Render environments as labels in Secrets table
-
74c1175a...5e26f833 - 2460 commits from branch
changed milestone to %17.2
added 1 commit
- 806b1969 - Render environments as labels in Secrets table
added 1 commit
- 5377e7b2 - Render environments as labels in Secrets table
- Resolved by Jose Ivan Vargas
Hey @thomasrandolph, are you free to give this small MR a review?
requested review from @thomasrandolph