Skip to content
Snippets Groups Projects

Render environments as labels in Secrets table

Merged Mireya Andres requested to merge ci/secret-render-env into master

What does this MR do and why?

Follow-up from !154536 (merged).

Because we changed the mock data in !154536 (merged), scoped labels (which are the same as environments, making this data redundant) are no longer shown. This MR fixes that so we render environments as scoped labels in the Secrets table.

Note that there's no backend integration for the Secrets Manager yet, so we're just working with mock data for now.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
Screenshot_2024-06-04_at_12.24.42 Screenshot_2024-06-04_at_12.34.19

How to set up and validate locally

  1. Enable the ci_tanukey_ui feature flag for your project.
    Feature.enable(:ci_tanukey_ui, <project>)
  2. Visit <path-to-project>/-/secrets.
Edited by Mireya Andres

Merge request reports

Merge train pipeline #1339440401 passed

Merge train pipeline passed for aea6697e

Merged by Jose Ivan VargasJose Ivan Vargas 9 months ago (Jun 19, 2024 6:31pm UTC)

Loading

Pipeline #1339441176 passed

Pipeline passed for dda409ff on master

Test coverage 64.10% from 0 jobs
10 environments impacted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading