Skip to content

Improve consistency between Group & Project Milestone creation/editing

Chad Lavimoniere requested to merge 454591-use-field-error-instead-of-alert-when-milestone-name-is-unavailable into master

What does this MR do and why?

  • Consolidates Milestone creation and editing form into a single shared form for group and project Miletones
  • Adds some information about the scope of the milestone to New milestone pages
  • Updates breadcrumbs, H1s and page titles for New and Edit milestone pages

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Changed feature Before After
New milestone form with a title error

image

image.png
New project milestone page breadcrumb

image

image.png

New group milestone page breadcrumb

(Unchanged)

image

image.png

New project milestone page title
(Unchanged)

Screenshot_2024-06-03_at_15.11.00__2_

Screenshot_2024-06-03_at_15.08.42__2_
New group milestone page title

Screenshot_2024-06-03_at_15.00.53__2_

Screenshot_2024-06-03_at_15.14.33__2_

Edit project milestone page title
(Unchanged)

Screenshot_2024-06-03_at_15.10.20__2_

Screenshot_2024-06-03_at_15.09.26__2_
Edit group milestone page title

Screenshot_2024-06-03_at_15.02.36__2_

Screenshot_2024-06-03_at_15.04.48__2_

Side by side

Before After
image.png image.png
image image.png

How to set up and validate locally

  1. Check out this branch locally
  2. visit a project milestones page. If there are no project milestones, create a new one. On the project milestones page, take note of the name of an existing project milestone
  3. Click "New milestone"
  4. Try to create a new project milestone with the same name as the milestone you took note of in step 2
  5. You will get a field-level error on the Title field saying that the name is already in use on another milestone
  6. Visit a group milestones page. If there are no group-level milestones, create one. On the group milestones page, take note of the name of an existing group milestone.
  7. Click "New milestone"
  8. Try to create a new group-level milestone with the same name as the milestone you took note of in step 6
  9. You will get a field-level error on the Title field saying that the name is already in use on another milestone
  10. Open the new group milestone form page in one tab and the new project milestone page in another. Compare the two and you will see that they are identical except that the URL, breadcrumb, title and group or project scope information displayed before the form are different.

Related to #454591

Edited by Chad Lavimoniere

Merge request reports