Skip to content

Replace "via" with "with" in issue email copy and timeline

Chad Lavimoniere requested to merge 456257-replace-via-in-issue-closure-email-copy into master

What does this MR do and why?

Change sentences like "Closed by Foo Bar via [MR id here]" to "Closed by Foo Bar with [MR id here]"

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

  1. Open http://gdk.test:3000/rails/letter_opener/ in a new tab. This will allow you to see/intercept all system emails sent in your GDK.
  2. In a separate tab or window, create an issue
  3. add some assignees
  4. create an MR from that issue that will close the issue
  5. open the MR branch in the Web IDE and make some changes. Commit them to the MR branch
  6. Merge the MR
  7. Confirm that the issue was closed via the MR.
  8. On the issue page, you will see that an event [Your username] closed with merge request [MR id here] (or it may reference the specific commit, but either way it will say with) appears
  9. Go back to the letter opener tab and refresh. You should see that there is at least one email (there will be one per assignee, so there may be multiple) that has copy like "Issue was closed by [Your user name here] with merge request [MR id here]" (or it may reference the specific commit instead of the MR, but either way it will say with not via.)

Related to #456257 (closed)

Related to #452225 (closed)

Edited by Chad Lavimoniere

Merge request reports