Skip to content
Snippets Groups Projects

Add feature flag check for project VSD link

Merged Ezekiel Kigbo requested to merge 454206-toggle-project-vsd-link into master

What does this MR do and why?

Disables the link to Value Streams Dashboards, when viewing Value Stream Analytics at the project level, unless the project_analytics_dashboard_dynamic_vsd feature flag is enabled.

Also ensures we always pass the namespace path to generateValueStreamsDashboardLink rather than the group path.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

FF Enabled FF Disabled
Screenshot_2024-05-29_at_15.02.06 Screenshot_2024-05-29_at_15.04.22

How to set up and validate locally

Note: You will need an GitLab Ultimate license

  1. Create a group with a single project in it
  2. Create a custom value stream and navigate to the VSA page for the project
    • There should not be a link to Value Streams Dashboard on the page
  3. Enable the project_analytics_dashboard_dynamic_vsd feature flag
  4. Navigate back to the VSA page for the project, there should be a link to the Project Value Streams Dashboard page
  5. Repeat for the group, but in this case the link will always be visible

Related to #454206 (closed)

Edited by Ezekiel Kigbo

Merge request reports

Merge train pipeline #1317033707 passed

Merge train pipeline passed for 9de53c4e

Merged by Elwyn BensonElwyn Benson 9 months ago (Jun 4, 2024 2:58am UTC)

Loading

Pipeline #1317034547 passed

Pipeline passed for f841a8e3 on master

Test coverage 64.21% from 0 jobs
10 environments impacted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • A deleted user added backend frontend labels

    added backend frontend labels

  • 2 Warnings

    featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.

    For more information, see:

    The master pipeline status page reported failures in

    If these jobs fail in your merge request with the same errors, then they are not caused by your changes.
    Please check for any on-going incidents in the incident issue tracker or in the #master-broken Slack channel.

    2 Messages
    📖 This merge request includes changes to Vue files that have both CE and EE versions.
    📖 CHANGELOG missing:

    If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog.

    If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

    Vue <template> in CE and EE

    Some Vue files in CE have a counterpart in EE. (For example, path/to/file.vue and ee/path/to/file.vue.)

    When run in the context of CE, the <template> of the CE Vue file is used. When run in the context of EE, the <template> of the EE Vue file is used.

    It's easy to accidentally make a change to a CE <template> that should appear in both CE and EE without making the change in both places. When this happens, the change only takes effect in CE.

    The following Vue files were changed as part of this merge request that include both a CE and EE version of the file:

    • app/assets/javascripts/analytics/cycle_analytics/components/base.vue
    • ee/app/assets/javascripts/analytics/cycle_analytics/components/base.vue

    If you made a change to the <template> of any of these Vue files that should be visible in both CE and EE, please ensure you have made your change to both versions of the file.

    A better alternative

    An even better alternative is to refactor this component to only use a single template for both CE and EE. More info on this approach here: https://docs.gitlab.com/ee/development/ee_features.html#template-tag

    Reviewer roulette

    Category Reviewer Maintainer
    backend @aish.sub profile link current availability (UTC-4, 14 hours behind author) @hraghuvanshi profile link current availability (UTC+5.5, 4.5 hours behind author)
    frontend @kpalchyk profile link current availability (UTC+3, 7 hours behind author) @leipert profile link current availability (UTC+2, 8 hours behind author)
    UX @lvanc profile link current availability (UTC-10, 20 hours behind author) Maintainer review is optional for UX

    Please check reviewer's status!

    • available Reviewer is available!
    • unavailable Reviewer is unavailable!

    Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

    If needed, you can retry the 🔁 danger-review job that generated this comment.

    Generated by 🚫 Danger

    Edited by Ghost User
  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 9190ef3b and 1f131f25

    Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 4.34 MB 4.34 MB - -0.0 %
    mainChunk 3.31 MB 3.31 MB - 0.0 %

    Please look at the full report for more details


    Read more about how this report works.

    Generated by 🚫 Danger

    Edited by Ghost User
  • Ezekiel Kigbo changed the description

    changed the description

  • added workflowin review label and removed workflowin dev label

  • Ezekiel Kigbo requested review from @aish.sub

    requested review from @aish.sub

  • Ezekiel Kigbo requested review from @nradina

    requested review from @nradina

  • Nataliia Radina approved this merge request

    approved this merge request

  • added pipelinetier-2 label and removed pipelinetier-1 label

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: test report for 1f131f25

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Data Stores | 31     | 0      | 0       | 0     | 31    | ✅     |
    | Verify      | 30     | 0      | 2       | 0     | 32    | ✅     |
    | Plan        | 54     | 0      | 2       | 0     | 56    | ✅     |
    | Govern      | 64     | 0      | 1       | 0     | 65    | ✅     |
    | Create      | 125    | 0      | 10      | 0     | 135   | ✅     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Package     | 19     | 0      | 12      | 0     | 31    | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Fulfillment | 1      | 0      | 0       | 0     | 1     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 339    | 0      | 28      | 0     | 367   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: test report for 1f131f25

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Plan        | 127    | 0      | 11      | 0     | 138   | ✅     |
    | Create      | 318    | 0      | 36      | 0     | 354   | ✅     |
    | Verify      | 8      | 0      | 2       | 0     | 10    | ✅     |
    | Data Stores | 22     | 0      | 0       | 0     | 22    | ✅     |
    | Govern      | 26     | 0      | 0       | 0     | 26    | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Package     | 6      | 0      | 8       | 0     | 14    | ✅     |
    | Release     | 2      | 0      | 0       | 0     | 2     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 517    | 0      | 57      | 0     | 574   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    Edited by Ghost User
  • added 1 commit

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading