Add feature flag check for project VSD link
What does this MR do and why?
Disables the link to Value Streams Dashboards, when viewing Value Stream Analytics at the project level, unless the project_analytics_dashboard_dynamic_vsd
feature flag is enabled.
Also ensures we always pass the namespace path to generateValueStreamsDashboardLink
rather than the group path.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
FF Enabled | FF Disabled |
---|---|
![]() |
![]() |
How to set up and validate locally
Note: You will need an GitLab Ultimate license
- Create a group with a single project in it
-
Create a custom value stream and navigate to the VSA page for the project
- There should not be a link to Value Streams Dashboard on the page
- Enable the
project_analytics_dashboard_dynamic_vsd
feature flag - Navigate back to the VSA page for the project, there should be a link to the Project Value Streams Dashboard page
- Repeat for the group, but in this case the link will always be visible
Related to #454206 (closed)
Merge request reports
Activity
changed milestone to %17.1
assigned to @ekigbo
added pipelinetier-1 label
- Resolved by Elwyn Benson
2 Warnings ⚠ featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
⚠ The master pipeline status page reported failures in If these jobs fail in your merge request with the same errors, then they are not caused by your changes.
Please check for any on-going incidents in the incident issue tracker or in the#master-broken
Slack channel.2 Messages 📖 This merge request includes changes to Vue files that have both CE and EE versions. 📖 CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Vue
<template>
in CE and EESome Vue files in CE have a counterpart in EE. (For example,
path/to/file.vue
andee/path/to/file.vue
.)When run in the context of CE, the
<template>
of the CE Vue file is used. When run in the context of EE, the<template>
of the EE Vue file is used.It's easy to accidentally make a change to a CE
<template>
that should appear in both CE and EE without making the change in both places. When this happens, the change only takes effect in CE.The following Vue files were changed as part of this merge request that include both a CE and EE version of the file:
app/assets/javascripts/analytics/cycle_analytics/components/base.vue
ee/app/assets/javascripts/analytics/cycle_analytics/components/base.vue
If you made a change to the
<template>
of any of these Vue files that should be visible in both CE and EE, please ensure you have made your change to both versions of the file.A better alternative
An even better alternative is to refactor this component to only use a single template for both CE and EE. More info on this approach here: https://docs.gitlab.com/ee/development/ee_features.html#template-tag
Reviewer roulette
Category Reviewer Maintainer backend @aish.sub
(UTC-4, 14 hours behind author)
@hraghuvanshi
(UTC+5.5, 4.5 hours behind author)
frontend @kpalchyk
(UTC+3, 7 hours behind author)
@leipert
(UTC+2, 8 hours behind author)
UX @lvanc
(UTC-10, 20 hours behind author)
Maintainer review is optional for UX Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
🔁 danger-review
job that generated this comment.Generated by
🚫 DangerEdited by Ghost UserBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 9190ef3b and 1f131f25
✨ Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.34 MB 4.34 MB - -0.0 % mainChunk 3.31 MB 3.31 MB - 0.0 %
Please look at the full report for more details
Read more about how this report works.
Generated by
🚫 DangerEdited by Ghost User- Resolved by Ezekiel Kigbo
Hi @aish.sub would you be free to review this small change?
added workflowin review label and removed workflowin dev label
requested review from @aish.sub
- Resolved by Elwyn Benson
requested review from @nradina
added pipeline:mr-approved label
- Resolved by Ezekiel Kigbo
👋 @nradina
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipelinetier-2 label and removed pipelinetier-1 label
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
✅ test report for 1f131f25expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Data Stores | 31 | 0 | 0 | 0 | 31 | ✅ | | Verify | 30 | 0 | 2 | 0 | 32 | ✅ | | Plan | 54 | 0 | 2 | 0 | 56 | ✅ | | Govern | 64 | 0 | 1 | 0 | 65 | ✅ | | Create | 125 | 0 | 10 | 0 | 135 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 19 | 0 | 12 | 0 | 31 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Fulfillment | 1 | 0 | 0 | 0 | 1 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 339 | 0 | 28 | 0 | 367 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
✅ test report for 1f131f25expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 127 | 0 | 11 | 0 | 138 | ✅ | | Create | 318 | 0 | 36 | 0 | 354 | ✅ | | Verify | 8 | 0 | 2 | 0 | 10 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Govern | 26 | 0 | 0 | 0 | 26 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Package | 6 | 0 | 8 | 0 | 14 | ✅ | | Release | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 517 | 0 | 57 | 0 | 574 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost User