Skip to content
Snippets Groups Projects

Draft: Add packager token

Closed David Pisek requested to merge poc/group-dependencies-packager-filtering into master
4 unresolved threads

What does this MR do and why?

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
1 ---
2 name: group_level_dependencies_filtering_by_packager
3 feature_issue_url:
  • 1 ---
    2 name: group_level_dependencies_filtering_by_packager
    3 feature_issue_url:
    4 introduced_by_url:
  • 3 Warnings
    :warning: ad2be0f2: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
    :warning: This merge request does not refer to an existing milestone.
    :warning: This merge request contains lines with testid selectors. Please ensure e2e:package-and-test job is run.
    1 Message
    :book: CHANGELOG missing:

    If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog.

    If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

    testid selectors

    The following changed lines in this MR contain testid selectors:

    ee/app/assets/javascripts/dependencies/components/filtered_search/tokens/package_manager_token.vue

    +      <gl-intersperse data-testid="selected-package-managers">
    +          data-testid="dynamic-scroller"

    If the e2e:package-and-test job in the qa stage has run automatically, please ensure the tests are passing. If the job has not run, please start the manual:e2e-test-pipeline-generate job in the prepare stage and ensure the tests in follow-up:e2e:package-and-test-ee pipeline are passing.

    For the list of known failures please refer to the latest pipeline triage issue.

    If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.

    Reviewer roulette

    Category Reviewer Maintainer
    backend @ahegyi profile link current availability (UTC+2, same timezone as author) @proglottis profile link current availability (UTC+12, 10 hours ahead of author)
    frontend @vvempati profile link current availability (UTC+12, 10 hours ahead of author) @slashmanov profile link current availability (UTC+4, 2 hours ahead of author)

    Please check reviewer's status!

    • available Reviewer is available!
    • unavailable Reviewer is unavailable!

    Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 36ecf818 and ad2be0f2

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 4.34 MB 4.34 MB - 0.0 %
    mainChunk 3.31 MB 3.31 MB - 0.0 %

    Note: We do not have exact data for 36ecf818. So we have used data from: 3b32adfc.
    The intended commit has no webpack pipeline, so we chose the last commit with one before it.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • David Pisek added 303 commits

    added 303 commits

    Compare with previous version

  • David Pisek added 763 commits

    added 763 commits

    Compare with previous version

  • David Pisek added 95 commits

    added 95 commits

    Compare with previous version

  • David Pisek added 1 commit

    added 1 commit

    Compare with previous version

  • David Pisek added 1 commit

    added 1 commit

    • 3a58222f - WIP: remove obsolute snapshot

    Compare with previous version

  • David Pisek added 195 commits

    added 195 commits

    Compare with previous version

  • David Pisek added 1 commit

    added 1 commit

    Compare with previous version

  • 69 data: this.active ? null : this.selectedPackageManagerNames,
    70 };
    71 },
    72 },
    73 created() {
    74 this.fetchPackageMangers();
    75 },
    76 methods: {
    77 async fetchPackageMangers() {
    78 try {
    79 this.isLoading = true;
    80 // Note: This is just a placeholder. Adding the actual fetch logic will be addressed in a separate issue:
    81 // https://gitlab.com/gitlab-org/gitlab/-/issues/442556
    82 // There is also a BE dependency that needs to be resolved, before we can fetch the actual data:
    83 // https://gitlab.com/gitlab-org/gitlab/-/issues/454302
    84 this.packageManagers = await new Promise((resolve) => {
  • David Pisek added 1 commit

    added 1 commit

    Compare with previous version

  • David Pisek added 1 commit

    added 1 commit

    Compare with previous version

  • David Pisek added 1 commit

    added 1 commit

    Compare with previous version

  • closed

  • Please register or sign in to reply
    Loading