Draft: Add packager token
What does this MR do and why?
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Merge request reports
Activity
assigned to @dpisek
- A deleted user
added backend feature flag frontend groupthreat insights labels
1 --- 2 name: group_level_dependencies_filtering_by_packager 3 feature_issue_url: changed this line in version 9 of the diff
added pipelinetier-1 label
added devopsgovern sectionsec labels
1 --- 2 name: group_level_dependencies_filtering_by_packager 3 feature_issue_url: 4 introduced_by_url: changed this line in version 9 of the diff
3 Warnings ad2be0f2: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. This merge request does not refer to an existing milestone. This merge request contains lines with testid selectors. Please ensure e2e:package-and-test
job is run.1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
testid
selectorsThe following changed lines in this MR contain
testid
selectors:ee/app/assets/javascripts/dependencies/components/filtered_search/tokens/package_manager_token.vue
+ <gl-intersperse data-testid="selected-package-managers"> + data-testid="dynamic-scroller"
If the
e2e:package-and-test
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start themanual:e2e-test-pipeline-generate
job in theprepare
stage and ensure the tests infollow-up:e2e:package-and-test-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Category Reviewer Maintainer backend @ahegyi
(UTC+2, same timezone as author)
@proglottis
(UTC+12, 10 hours ahead of author)
frontend @vvempati
(UTC+12, 10 hours ahead of author)
@slashmanov
(UTC+4, 2 hours ahead of author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger@dpisek
- please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request.
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 36ecf818 and ad2be0f2
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.34 MB 4.34 MB - 0.0 % mainChunk 3.31 MB 3.31 MB - 0.0 %
Note: We do not have exact data for 36ecf818. So we have used data from: 3b32adfc.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded 303 commits
-
67049548...6be2eacc - 302 commits from branch
master
- 5c29769c - WIP: Add packager token
-
67049548...6be2eacc - 302 commits from branch
added 763 commits
-
5c29769c...49015683 - 762 commits from branch
master
- 8c12b015 - WIP: Add packager token
-
5c29769c...49015683 - 762 commits from branch
added 95 commits
-
8c12b015...86f9f7f6 - 94 commits from branch
master
- b90e23e6 - WIP: Add packager token
-
8c12b015...86f9f7f6 - 94 commits from branch
added 195 commits
-
3a58222f...bf28fbd5 - 193 commits from branch
master
- 32d906df - WIP: Add packager token
- 87b6b5c2 - WIP: remove obsolute snapshot
-
3a58222f...bf28fbd5 - 193 commits from branch
69 data: this.active ? null : this.selectedPackageManagerNames, 70 }; 71 }, 72 }, 73 created() { 74 this.fetchPackageMangers(); 75 }, 76 methods: { 77 async fetchPackageMangers() { 78 try { 79 this.isLoading = true; 80 // Note: This is just a placeholder. Adding the actual fetch logic will be addressed in a separate issue: 81 // https://gitlab.com/gitlab-org/gitlab/-/issues/442556 82 // There is also a BE dependency that needs to be resolved, before we can fetch the actual data: 83 // https://gitlab.com/gitlab-org/gitlab/-/issues/454302 84 this.packageManagers = await new Promise((resolve) => { mentioned in issue gitlab-org/quality/triage-reports#20603 (closed)
mentioned in issue gitlab-org/quality/triage-reports#20965 (closed)
mentioned in issue gitlab-org/quality/triage-reports#21545 (closed)
mentioned in issue gitlab-org/quality/triage-reports#22021 (closed)