Skip to content
Snippets Groups Projects

Fix E2E govern specs for filtered search feature flag

All threads resolved!

What does this MR do and why?

Fix change vulnerability status spec to work in both feature flag states for vulnerability_report_advanced_filtering FF.

Relates to: #461959 (closed)

To run against gdk:


WEBDRIVER_HEADLESS=false GITLAB_ADMIN_PASSWORD="password" GITLAB_QA_ADMIN_ACCESS_TOKEN=token GITLAB_PASSWORD="password" QA_LOG_LEVEL=DEBUG QA_GITLAB_URL=http://172.16.123.1:3000 bundle exec rspec  ./qa/specs/features/ee/browser_ui/10_govern/change_vulnerability_status_spec.rb

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Harsha Muralidhar

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Harsha Muralidhar changed milestone to %17.1

    changed milestone to %17.1

  • Harsha Muralidhar changed the description

    changed the description

  • 1 Message
    :book: CHANGELOG missing:

    If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog.

    If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

    Reviewer roulette

    Category Reviewer Maintainer
    QA @bwilkerson13 profile link current availability (UTC-5, 15 hours behind author) @sliaquat profile link current availability (UTC+5, 5 hours behind author)

    Please check reviewer's status!

    • available Reviewer is available!
    • unavailable Reviewer is unavailable!

    Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

    • Resolved by Sanad Liaquat

      E2E Test Result Summary

      allure-report-publisher generated test report!

      e2e-test-on-gdk: :white_check_mark: test report for e4fac5fb

      expand test summary
      +------------------------------------------------------------------+
      |                          suites summary                          |
      +-------------+--------+--------+---------+-------+-------+--------+
      |             | passed | failed | skipped | flaky | total | result |
      +-------------+--------+--------+---------+-------+-------+--------+
      | Data Stores | 31     | 0      | 0       | 0     | 31    | ✅     |
      | Create      | 111    | 0      | 9       | 0     | 120   | ✅     |
      | Package     | 19     | 0      | 12      | 0     | 31    | ✅     |
      | Plan        | 54     | 0      | 2       | 0     | 56    | ✅     |
      | Govern      | 66     | 0      | 0       | 0     | 66    | ✅     |
      | Verify      | 31     | 0      | 1       | 0     | 32    | ✅     |
      | Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
      | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
      | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
      | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
      +-------------+--------+--------+---------+-------+-------+--------+
      | Total       | 327    | 0      | 25      | 0     | 352   | ✅     |
      +-------------+--------+--------+---------+-------+-------+--------+

      e2e-test-on-cng: :x: test report for e4fac5fb

      expand test summary
      +------------------------------------------------------------------+
      |                          suites summary                          |
      +-------------+--------+--------+---------+-------+-------+--------+
      |             | passed | failed | skipped | flaky | total | result |
      +-------------+--------+--------+---------+-------+-------+--------+
      | Plan        | 101    | 0      | 8       | 0     | 109   | ✅     |
      | Fulfillment | 2      | 0      | 25      | 0     | 27    | ✅     |
      | Create      | 156    | 3      | 22      | 0     | 181   | ❌     |
      | Govern      | 94     | 0      | 6       | 0     | 100   | ✅     |
      | Verify      | 55     | 0      | 10      | 0     | 65    | ✅     |
      | Package     | 26     | 0      | 19      | 0     | 45    | ✅     |
      | Monitor     | 12     | 0      | 8       | 0     | 20    | ✅     |
      | Manage      | 2      | 0      | 3       | 0     | 5     | ✅     |
      | Data Stores | 45     | 0      | 9       | 0     | 54    | ✅     |
      | Release     | 6      | 0      | 1       | 0     | 7     | ✅     |
      | Secure      | 3      | 0      | 1       | 0     | 4     | ✅     |
      | ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
      | Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
      | Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
      | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
      | Ai-powered  | 0      | 0      | 1       | 0     | 1     | ➖     |
      +-------------+--------+--------+---------+-------+-------+--------+
      | Total       | 504    | 3      | 119     | 0     | 626   | ❌     |
      +-------------+--------+--------+---------+-------+-------+--------+

      e2e-package-and-test: :x: test report for e4fac5fb

      expand test summary
      +---------------------------------------------------------------------+
      |                           suites summary                            |
      +----------------+--------+--------+---------+-------+-------+--------+
      |                | passed | failed | skipped | flaky | total | result |
      +----------------+--------+--------+---------+-------+-------+--------+
      | Create         | 411    | 9      | 47      | 0     | 467   | ❌     |
      | Ai-powered     | 0      | 0      | 1       | 0     | 1     | ➖     |
      | Plan           | 83     | 0      | 7       | 0     | 90    | ✅     |
      | Systems        | 7      | 0      | 0       | 0     | 7     | ✅     |
      | Govern         | 107    | 0      | 5       | 0     | 112   | ✅     |
      | Package        | 114    | 7      | 44      | 0     | 165   | ❌     |
      | Fulfillment    | 4      | 0      | 25      | 0     | 29    | ✅     |
      | GitLab Metrics | 2      | 0      | 1       | 0     | 3     | ✅     |
      | Analytics      | 3      | 0      | 0       | 0     | 3     | ✅     |
      | Manage         | 18     | 2      | 6       | 0     | 26    | ❌     |
      | Verify         | 50     | 0      | 10      | 0     | 60    | ✅     |
      | Data Stores    | 47     | 0      | 10      | 0     | 57    | ✅     |
      | Configure      | 1      | 0      | 3       | 0     | 4     | ✅     |
      | Monitor        | 12     | 0      | 9       | 0     | 21    | ✅     |
      | Release        | 5      | 0      | 1       | 0     | 6     | ✅     |
      | Secure         | 3      | 0      | 1       | 0     | 4     | ✅     |
      | ModelOps       | 0      | 0      | 1       | 0     | 1     | ➖     |
      | Growth         | 0      | 0      | 2       | 0     | 2     | ➖     |
      +----------------+--------+--------+---------+-------+-------+--------+
      | Total          | 867    | 18     | 173     | 0     | 1058  | ❌     |
      +----------------+--------+--------+---------+-------+-------+--------+
  • requested review from @lorenzvanherwaarden

  • mentioned in epic &13339 (closed)

  • Lorenz van Herwaarden approved this merge request

    approved this merge request

  • Harsha Muralidhar
  • requested review from @bwilkerson13 and @sliaquat

  • Sanad Liaquat
  • Sanad Liaquat resolved all threads

    resolved all threads

  • Sanad Liaquat approved this merge request

    approved this merge request

  • @sliaquat, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 4 hours ago, you should:

    1. Ensure the merge request is not in Draft status.
    2. Start a pipeline (especially important for Community contribution merge requests).
    3. Set the merge request to auto-merge.

    This is a guideline, not a rule. Please consider replying to this comment for transparency.

    This message was generated automatically. You're welcome to improve it.

  • Sanad Liaquat mentioned in commit 9ad6f23d

    mentioned in commit 9ad6f23d

  • added workflowstaging label and removed workflowcanary label

  • Savas Vedova resolved all threads

    resolved all threads

  • Savas Vedova mentioned in issue #462645

    mentioned in issue #462645

  • Please register or sign in to reply
    Loading