Remove Vue set for vue 3 migration
What does this MR do and why?
Describe in detail what your merge request does and why.
This MR partially resolves #452467 (closed)
What was cleaned up from epic:
- Remove
Vue.set
Vue set is no longer supported in VUE 3
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
NO VISUAL CHANGES
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Checkout branch
- Run test locally
- Or just check in pipeline
- Run it also with
VUE_VERSION=3 yarn jest --watch
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @arfedoro
1 Warning This merge request does not refer to an existing milestone. 1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer frontend @apennells
(UTC-4, 6 hours behind author)
@ohoral
(UTC+2, same timezone as author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Olena Horal-Koretska
@aalakkad could you please review this MR?
requested review from @aalakkad
added pipelinetier-1 label
added pipeline:mr-approved label
- Resolved by Olena Horal-Koretska
@aalakkad
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipelinetier-2 label and removed pipelinetier-1 label
- Resolved by Olena Horal-Koretska
@arfedoro - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request.
added pipelinetier-3 label and removed pipelinetier-2 label
added typemaintenance label
enabled an automatic merge when the pipeline for 1a2c5435 succeeds
added 613 commits
-
aed21189...2008657d - 612 commits from branch
master
- 9e680cc6 - Remove Vue set for vue 3 migration
-
aed21189...2008657d - 612 commits from branch
Generated bygitlab_quality-test_tooling
.
Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.Click to expand
Job File Name Duration Expected duration #6906359944 spec/features/projects/badges/list_spec.rb#L44
list of badges user changes current ref of build status badge 65.49 s < 50.13 s - A deleted user
added rspec:slow test detected label
added 363 commits
-
9e680cc6...8831128b - 362 commits from branch
master
- bab67952 - Remove Vue set for vue 3 migration
-
9e680cc6...8831128b - 362 commits from branch
enabled an automatic merge when the pipeline for a84bcc75 succeeds
mentioned in commit 63dfea60
added workflowstaging-canary label
changed milestone to %17.1
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label