Add Danger rule to verify fields for removed metrics
requested to merge 390871-fail-the-danger-job-for-metrics-with-status-changed-to-removed-with-no-removed_by_url-value into master
What does this MR do and why?
A missing removed_by_url or milestone_removed attribute often only gets discovered during review.
This MR adds new Dangerbot rule to verify the fields are present when metric is being removed.
If no milestone set for MR, Danger adds suggestions with placeholder and comment text.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
See an example MR with the all 3 above check in place: !153340 (closed)
How to set up and validate locally
You can change status for any metrics to removed and then bin/rake danger_local command to execute the checks.
Related to #390871 (closed)
Edited by Niko Belokolodov