Fail the danger job for metrics with status changed to `removed` with no `removed_by_url` value
Problem
A missing removed_by_url
or milestone_removed
attribute often only gets discovered during review
Desired Outcome
Missing removed_by_url
or milestone_removed
are discovered early before human review.
Proposed Solution
To optimize the reviews, we can add a check that makes sure new removed metrics get a removed_by_url
and milestone_removed
attribute.
We should be able to handle that using Danger: https://gitlab.com/gitlab-org/gitlab/blob/master/tooling/danger/product_intelligence.rb#L6
Example MR changes where adding the attribute with a different name didn't cause the CI pipeline to fail: !111351 (diffs)
Edited by Sebastian Rehm