Skip to content

Don't include FF patch files in YAML validation

Dylan Griffith requested to merge dont-include-patch-files-in-ff-yaml-validation into master

What does this MR do and why?

In !144174 (merged) we introduced something that validates all newly added feature flag definition files. But it's doing this by looking for all files in the config/feature_flags directory. But since we introduced https://docs.gitlab.com/ee/development/feature_flags/#optionally-add-a-patch-file-for-automated-removal-of-feature-flags we allow people to optionally put a patch file for their feature flags.

Since the danger job is validating all newly added files this is breaking any new MRs (e.g. !149039 (merged) ) which are adding patch files.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Dylan Griffith

Merge request reports