Enable menu items from custom permissions
What does this MR do and why?
This MR was extracted from !151825 (merged) after a merge conflict was caused from !150415 (merged), !151677 (merged) and !151586 (merged). This change attempts to reduce the churn caused in this file from adding new permissions to support Custom Roles.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Merge request reports
Activity
changed milestone to %17.1
added backend groupauthorization maintenancerefactor labels
assigned to @mokhax
added typemaintenance label
added Category:Permissions devopsgovern sectionsec labels
Reviewer roulette
Category Reviewer Maintainer backend @shreyasagarwal
(UTC+2, 8 hours ahead of author)
@ashmckenzie
(UTC+10, 16 hours ahead of author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 1 commit
- d0c084f6 - Use a table test to test menu items for custom roles
- Resolved by Dmitry Gruzd
@alexbuijs, @hmehra do you mind reviewing this change since you have some familiarity and context?
requested review from @alexbuijs and @hmehra
mentioned in issue #442851 (closed)
requested review from @dgruzd and removed review request for @alexbuijs
added pipeline:mr-approved label
added workflowin review label
- Resolved by Dmitry Gruzd
@dgruzd
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
Generated bygitlab_quality-test_tooling
.
Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.Click to expand
Job File Name Duration Expected duration #6840155532 spec/features/ide_spec.rb#L48
IDE with vscode feature flag off behaves like legacy Web IDE loads legacy Web IDE 67.04 s < 50.13 s #6840155532 spec/features/ide_spec.rb#L62
IDE sub-groups behaves like legacy Web IDE loads legacy Web IDE 65.92 s < 50.13 s - A deleted user
added rspec:slow test detected label
added pipelinetier-3 label
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 9079664fexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Package | 19 | 0 | 12 | 19 | 31 | ✅ | | Monitor | 8 | 0 | 0 | 7 | 8 | ✅ | | Create | 111 | 0 | 9 | 94 | 120 | ✅ | | Govern | 66 | 0 | 0 | 43 | 66 | ✅ | | Verify | 31 | 0 | 1 | 30 | 32 | ✅ | | Plan | 54 | 0 | 2 | 47 | 56 | ✅ | | Data Stores | 31 | 0 | 0 | 22 | 31 | ✅ | | Release | 5 | 0 | 0 | 5 | 5 | ✅ | | Analytics | 2 | 0 | 0 | 1 | 2 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 327 | 0 | 25 | 268 | 352 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 9079664fexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 121 | 0 | 5 | 3 | 126 | ✅ | | Create | 297 | 0 | 31 | 0 | 328 | ✅ | | Verify | 5 | 0 | 0 | 0 | 5 | ✅ | | Plan | 22 | 0 | 2 | 0 | 24 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Data Stores | 11 | 0 | 0 | 0 | 11 | ✅ | | Release | 1 | 0 | 0 | 0 | 1 | ✅ | | Package | 3 | 0 | 4 | 0 | 7 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 464 | 0 | 42 | 3 | 506 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
- Resolved by Dmitry Gruzd
It looks like this MR has a merge conflict with !151586 (merged). I'll resolve and push up a new commit but I will probably need re-approvals.
added 332 commits
-
d0c084f6...dfe8b46b - 331 commits from branch
master
- 85fbeb55 - Replace conditionals with Hash
-
d0c084f6...dfe8b46b - 331 commits from branch
reset approvals from @dgruzd by pushing to the branch
requested review from @alexbuijs and removed review request for @hmehra
added pipelinetier-2 label and removed pipelinetier-3 label
added pipelinetier-3 label and removed pipelinetier-2 label
enabled an automatic merge when the pipeline for b5a15858 succeeds
- Resolved by Dmitry Gruzd
@mokhax There are some failures in the pipeline. Could I ask you to take a look? Thanks!
removed review request for @dgruzd
removed review request for @alexbuijs
added 1 commit
- 9079664f - Restore old trait and remove unrecognized one
reset approvals from @dgruzd by pushing to the branch
requested review from @dgruzd
added pipelinetier-2 label and removed pipelinetier-3 label
added pipelinetier-3 label and removed pipelinetier-2 label
enabled an automatic merge when the pipeline for dc71a956 succeeds
mentioned in commit 3ebd720a
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label