Skip to content

Correct contradictory explanation of GitLab Helm Chart values removal

John Gaughan requested to merge jgaughan-master-patch-11758 into master
  • Please check this box if this contribution uses AI-generated content as outlined in the GitLab DCO & CLA.

What does this MR do?

The current language for this breaking change entry states that the deprecated GitLab Helm Chart values will be removed in GitLab Runner Helm Chart v1.0.

From this MR, there was some conversation that we would release Runner Helm Chart v1.0 alongside GitLab 16.0. That didn't happen: version 0.53.0 was released with GitLab 16.0. However, the breaking change was still introduced.

The current language is contradictory since v1.0 still hasn't been released. This MR gets rid of the reference to v1.0 and clarifies that the breaking change already occurred.

Related issues

#379064 (closed)

Author's checklist

If you are a GitLab team member and only adding documentation, do not add any of the following labels:

  • ~"frontend"
  • ~"backend"
  • ~"type::bug"
  • ~"database"

These labels cause the MR to be added to code verification QA issues.

Reviewer's checklist

Documentation-related MRs should be reviewed by a Technical Writer for a non-blocking review, based on Documentation Guidelines and the Style Guide.

If you aren't sure which tech writer to ask, use roulette or ask in the #docs Slack channel.

  • If the content requires it, ensure the information is reviewed by a subject matter expert.
  • Technical writer review items:
    • Ensure docs metadata is present and up-to-date.
    • Ensure the appropriate labels are added to this MR.
    • Ensure a release milestone is set.
    • If relevant to this MR, ensure content topic type principles are in use, including:
      • The headings should be something you'd do a Google search for. Instead of Default behavior, say something like Default behavior when you close an issue.
      • The headings (other than the page title) should be active. Instead of Configuring GDK, say something like Configure GDK.
      • Any task steps should be written as a numbered list.
      • If the content still needs to be edited for topic types, you can create a follow-up issue with the docs-technical-debt label.
  • Review by assigned maintainer, who can always request/require the reviews above. Maintainer's review can occur before or after a technical writer review.

Merge request reports