Skip to content

Correctly set group setting when building group

Pedro Pombeiro (OOO from July 16th till Aug 7th) requested to merge pedropombeiro/413956/fix-default-value-on-top-most-groups into master

What does this MR do and why?

This MR moves the logic that sets the allow_runner_registration_token namespace preference from a group hook to Groups::CreateService, where it belongs. It fixes the problem detailed in !150562 (comment 1897818693), where we're not seeing the preference being set for new top-level groups in prod.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

n/a

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

n/a

Edited by Pedro Pombeiro (OOO from July 16th till Aug 7th)

Merge request reports