Skip to content

Disable runner registration tokens for all groups on .com

Pedro Pombeiro requested to merge pedropombeiro/413956/2-disable-runner-registration-tokens-on-groups into master

🚨 🚨 NOTE: This MR should only be merged on May 6th-7th, in time for the 3rd breaking changes window (2024-05-06 09:00 UTC to 2024-05-08 22:00 UTC) 🚨 🚨

What does this MR do and why?

This MR disables runner registration tokens for all groups on .com (not for Dedicated though, that is being handled in !150648 (merged)). The idea is to force customers who still rely on runner registration tokens to take an explicit step to re-enable them, if they cannot yet migrate to the new runner creation workflow. Runner registration tokens will be removed in %18.0.

The MR schedules a batched background migration that is a no-op for self-managed instances (it is also EE-only). We should strive for the batched background migration to finish within the breaking changes window (~2.5 days).

Changelog: changed

Closes #413956 (closed)

Notes

I've taken a look at the production main database, and came up with the following conclusions:

  • All the top-most namespaces that don't represent a user are of type Group.
  • All the top-most groups have a respective namespace_settings row (none is falling back on a default).
  • We have almost 4M records to update.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

n/a

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

n/a

Edited by Pedro Pombeiro

Merge request reports