Skip to content

Fix drag-and-drop on Firefox

Jack Chapman requested to merge jachapman-fix-ff-drag-and-drop into master

What does this MR do and why?

Fixes issue where dragging and dropping issues over issue titles will open modals or click links and sometimes cancel the re-ordering the user intends.

I attempted to fix this using css (pointer-events: none;) but had limited success — it didn't consistently work across both pages. So instead I took the approach to swap the elements from gl-links to ps while dragging.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Here are recordings of the behaviour before this fix is applied.

Epic Work Item Drag and Drop Legacy Epic Drag and Drop

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

For namespace level work items:

  1. Using Firefox, navigate to a work item that uses the 'child items' widget
  2. Click and drag a linked item, making sure to hover the mouse over the title link of the 'ghost element' below the dragged element.
  3. Before this change, you would trigger a modal to open.
  4. After this change, nothing extra happens.

For legacy epics:

  1. Using Firefox, navigate to an epic with some child issues/epics
  2. Click and drag a child item, making sure to start the drag by clicking on the issue title.
  3. Before this change, ending the drag would click the link and navigate you away.
  4. After this change, nothing extra happens.

Relates to #34243, but doesn't fix it directly.

Edited by Jack Chapman

Merge request reports