Skip to content

Remove duplicate footer for merge request approval mails

Martin Schurz requested to merge gitlab-community/gitlab:mail_footer into master
  • Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA

What does this MR do and why?

Remove duplicate footer for merge request mails

Mails for merge requests use threaded mails and include a default footer. This makes sense for discussions but not for system notifications. We now remove the duplicate footer but keep the threaded mail workflow because some folks might rely on this for sorting their inbox or replying to notifications.

Solution for #1898

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
image image
image image
image image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. http://localhost:3000/rails/mailers/notify/approved_merge_request_email
  2. http://localhost:3000/rails/mailers/notify/merge_when_pipeline_succeeds_email
  3. http://localhost:3000/rails/mailers/notify/unapproved_merge_request_email
Edited by Martin Schurz

Merge request reports