Add require_reauthentication_to_approve
What does this MR do and why?
Add require_reauthentication_to_approve
-
In an effor to rename require_password_to_approve to reflect that it can reference either SAML or password authentication we are adding this merge request approval setting field as its replacement
-
Refs: #431346
Changelog: changed EE: true
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Merge request reports
Activity
assigned to @sam.figueroa
added devopsgovern label
- A deleted user
added backend label
- Resolved by Thong Kuah
3 Warnings This merge request is quite big (519 lines changed), please consider splitting it into multiple merge requests. The merge request title must contain at least 3 words. For more information, take a look at our Commit message guidelines. The master pipeline status page reported failures in If these jobs fail in your merge request with the same errors, then they are not caused by your changes.
Please check for any on-going incidents in the incident issue tracker or in the#master-broken
Slack channel.1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/api/merge_request_approvals.md
(Link to current live version) -
doc/user/compliance/audit_event_types.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Category Reviewer Maintainer backend @tyleramos
(UTC-4, 4 hours behind author)
@ck3g
(UTC+2, 2 hours ahead of author)
QA @AndyWH
(UTC-7, 7 hours behind author)
Maintainer review is optional for QA Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger -
added 1943 commits
-
c3838631...491d3185 - 1942 commits from branch
master
- 8561145b - Add require_reauthentication_to_approve
-
c3838631...491d3185 - 1942 commits from branch
added 1 commit
- 14101fb7 - Rename for reauthentication vs just password
- A deleted user
added QA label
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 93a1a6adexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 56 | 0 | 2 | 0 | 58 | ✅ | | Govern | 65 | 0 | 0 | 0 | 65 | ✅ | | Create | 122 | 0 | 10 | 0 | 132 | ✅ | | Verify | 30 | 0 | 2 | 0 | 32 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Package | 19 | 0 | 12 | 0 | 31 | ✅ | | Data Stores | 31 | 0 | 0 | 0 | 31 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Fulfillment | 1 | 0 | 0 | 0 | 1 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 339 | 0 | 27 | 0 | 366 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for 93a1a6adexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 139 | 0 | 15 | 0 | 154 | ✅ | | Govern | 79 | 0 | 9 | 0 | 88 | ✅ | | Data Stores | 34 | 0 | 9 | 0 | 43 | ✅ | | Plan | 83 | 0 | 6 | 0 | 89 | ✅ | | Verify | 55 | 0 | 11 | 0 | 66 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Package | 23 | 0 | 15 | 0 | 38 | ✅ | | Manage | 2 | 0 | 8 | 0 | 10 | ✅ | | Fulfillment | 2 | 0 | 24 | 0 | 26 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Secure | 3 | 0 | 1 | 0 | 4 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Ai-powered | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 435 | 0 | 118 | 0 | 553 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 93a1a6adexpand test summary
+---------------------------------------------------------------------+ | suites summary | +----------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------+--------+--------+---------+-------+-------+--------+ | Govern | 108 | 1 | 8 | 0 | 117 | ❌ | | Systems | 7 | 0 | 0 | 0 | 7 | ✅ | | Plan | 88 | 0 | 6 | 0 | 94 | ✅ | | Manage | 30 | 0 | 15 | 0 | 45 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Create | 425 | 0 | 45 | 2 | 470 | ✅ | | Verify | 55 | 0 | 11 | 0 | 66 | ✅ | | Configure | 1 | 0 | 3 | 0 | 4 | ✅ | | Analytics | 3 | 0 | 0 | 0 | 3 | ✅ | | Package | 31 | 0 | 14 | 4 | 45 | ✅ | | Fulfillment | 4 | 0 | 24 | 0 | 28 | ✅ | | Data Stores | 47 | 0 | 10 | 0 | 57 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Monitor | 12 | 0 | 13 | 0 | 25 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Secure | 3 | 0 | 1 | 0 | 4 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | +----------------+--------+--------+---------+-------+-------+--------+ | Total | 821 | 1 | 157 | 6 | 979 | ❌ | +----------------+--------+--------+---------+-------+-------+--------+
added 1 commit
- 2b2a0e5f - Rename for reauthentication vs just password
- Resolved by Thong Kuah
added 1290 commits
-
2b2a0e5f...3e7353b6 - 1289 commits from branch
master
- f4940c97 - Rename for reauthentication vs just password
-
2b2a0e5f...3e7353b6 - 1289 commits from branch
- A deleted user
added documentation label
added 2007 commits
-
f4940c97...53e22f2c - 2006 commits from branch
master
- 7866cdf5 - Rename for reauthentication vs just password
-
f4940c97...53e22f2c - 2006 commits from branch
added pipelinetier-1 label
requested review from @eread and @hraghuvanshi
- Resolved by SAM FIGUEROA
- Resolved by SAM FIGUEROA
- Resolved by SAM FIGUEROA
- Resolved by Evan Read
- Resolved by Evan Read
- Resolved by Evan Read
- Resolved by SAM FIGUEROA
changed milestone to %17.0
added Technical Writing docsimprovement labels
removed review request for @eread
changed milestone to %17.1
added 1 commit
- 29df4b20 - Rename for reauthentication vs just password
removed review request for @hraghuvanshi
- Resolved by SAM FIGUEROA
- Resolved by SAM FIGUEROA
- Resolved by SAM FIGUEROA
- Resolved by SAM FIGUEROA
- Resolved by SAM FIGUEROA
mentioned in merge request !153923 (merged)
mentioned in commit 2b4cfbb1
added 2150 commits
-
29df4b20...4c46157a - 2149 commits from branch
master
- 2b4cfbb1 - Rename for reauthentication vs just password
-
29df4b20...4c46157a - 2149 commits from branch
requested review from @hraghuvanshi
- Resolved by SAM FIGUEROA
mentioned in epic &12035
- Resolved by SAM FIGUEROA
- Resolved by SAM FIGUEROA
- Resolved by SAM FIGUEROA
- Resolved by SAM FIGUEROA
- Resolved by Hitesh Raghuvanshi
- Resolved by Hitesh Raghuvanshi
- Resolved by SAM FIGUEROA
- Resolved by Hitesh Raghuvanshi
- Resolved by Hitesh Raghuvanshi
- Resolved by SAM FIGUEROA
removed review request for @hraghuvanshi
mentioned in commit ed8f7d4b
added 1379 commits
-
55bd90dc...edf585ed - 1378 commits from branch
master
- ed8f7d4b - Rename for reauthentication vs just password
-
55bd90dc...edf585ed - 1378 commits from branch
mentioned in commit 2c20801d
added 1 commit
- 2c20801d - Rename for reauthentication vs just password
mentioned in commit b2ae385d
added 1 commit
- b2ae385d - Rename for reauthentication vs just password
requested review from @hraghuvanshi
requested review from @a_akgun
added pipeline:mr-approved label
- Resolved by Thong Kuah
@hraghuvanshi
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipelinetier-3 label and removed pipelinetier-1 label
removed review request for @hraghuvanshi
Generated bygitlab_quality-test_tooling
.
Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.Click to expand
Job File Name Duration Expected duration #7057240679 spec/lib/release_highlights/validator_spec.rb#L82
ReleaseHighlights::Validator when validating all files they should have no errors 71.18 s < 27.12 s #7096332990 spec/lib/release_highlights/validator_spec.rb#L82
ReleaseHighlights::Validator when validating all files they should have no errors 70.46 s < 27.12 s #7096333263 ee/spec/lib/ee/search/settings_spec.rb#L19
Search results for settings behaves like all sections exist and have correct anchor links has only valid settings sections 49.95 s < 27.12 s #7096692007 spec/lib/release_highlights/validator_spec.rb#L82
ReleaseHighlights::Validator when validating all files they should have no errors 76.68 s < 27.12 s #7110796891 ee/spec/lib/ee/search/settings_spec.rb#L19
Search results for settings behaves like all sections exist and have correct anchor links has only valid settings sections 36.94 s < 27.12 s #7110796787 spec/lib/search/settings_spec.rb#L6
Search results for settings behaves like all sections exist and have correct anchor links has only valid settings sections 47.02 s < 27.12 s #7110796754 spec/lib/release_highlights/validator_spec.rb#L82
ReleaseHighlights::Validator when validating all files they should have no errors 86.61 s < 27.12 s #7110975769 spec/lib/release_highlights/validator_spec.rb#L82
ReleaseHighlights::Validator when validating all files they should have no errors 65.28 s < 27.12 s #7110975923 ee/spec/lib/ee/search/settings_spec.rb#L19
Search results for settings behaves like all sections exist and have correct anchor links has only valid settings sections 45.34 s < 27.12 s #7110975785 spec/lib/search/settings_spec.rb#L6
Search results for settings behaves like all sections exist and have correct anchor links has only valid settings sections 30.93 s < 27.12 s - A deleted user
added rspec:slow test detected label
- Resolved by SAM FIGUEROA
- Resolved by Thong Kuah
- Resolved by Thong Kuah
- Resolved by Thong Kuah
- Resolved by Thong Kuah
Thanks for this MR @sam.figueroa, nice work
Only for a few questions from me
removed review request for @tkuah
requested review from @tkuah
mentioned in commit c01ca6d1
added 2308 commits
-
b2ae385d...5b31a5c7 - 2307 commits from branch
master
- c01ca6d1 - Rename for reauthentication vs just password
-
b2ae385d...5b31a5c7 - 2307 commits from branch
reset approvals from @hraghuvanshi by pushing to the branch
requested review from @eread
- Resolved by Evan Read
- Resolved by Evan Read
- Resolved by Evan Read
reset approvals from @eread by pushing to the branch
enabled automatic add to merge train when the pipeline for 3dab0851 succeeds
Looks like we had a broken master, fixed in !156450 (merged). Starting a new pipeline...
mentioned in commit 3388539e
mentioned in commit a6a1e0ef
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in commit 01d37529
mentioned in merge request !156554 (merged)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in commit a0a0f4a5
mentioned in commit 8b264109
mentioned in merge request kubitus-project/kubitus-installer!3098 (merged)
mentioned in merge request !158648 (merged)