Skip to content
Snippets Groups Projects

Add require_reauthentication_to_approve

All threads resolved!

What does this MR do and why?

Add require_reauthentication_to_approve

  • In an effor to rename require_password_to_approve to reflect that it can reference either SAML or password authentication we are adding this merge request approval setting field as its replacement

  • Refs: #431346

Changelog: changed EE: true

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • A deleted user added backend label

    added backend label

    • Resolved by Thong Kuah
      3 Warnings
      :warning: This merge request is quite big (519 lines changed), please consider splitting it into multiple merge requests.
      :warning: The merge request title must contain at least 3 words. For more information, take a look at our Commit message guidelines.
      :warning: The master pipeline status page reported failures in

      If these jobs fail in your merge request with the same errors, then they are not caused by your changes.
      Please check for any on-going incidents in the incident issue tracker or in the #master-broken Slack channel.

      1 Message
      :book: This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge.

      Documentation review

      The following files require a review from a technical writer:

      The review does not need to block merging this merge request. See the:

      Reviewer roulette

      Category Reviewer Maintainer
      backend @tyleramos profile link current availability (UTC-4, 4 hours behind author) @ck3g profile link current availability (UTC+2, 2 hours ahead of author)
      QA @AndyWH profile link current availability (UTC-7, 7 hours behind author) Maintainer review is optional for QA

      Please check reviewer's status!

      • available Reviewer is available!
      • unavailable Reviewer is unavailable!

      Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

      If needed, you can retry the :repeat: danger-review job that generated this comment.

      Generated by :no_entry_sign: Danger

  • SAM FIGUEROA added 1943 commits

    added 1943 commits

    Compare with previous version

  • SAM FIGUEROA added 1 commit

    added 1 commit

    • 14101fb7 - Rename for reauthentication vs just password

    Compare with previous version

  • A deleted user added QA label

    added QA label

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 93a1a6ad

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Plan        | 56     | 0      | 2       | 0     | 58    | ✅     |
    | Govern      | 65     | 0      | 0       | 0     | 65    | ✅     |
    | Create      | 122    | 0      | 10      | 0     | 132   | ✅     |
    | Verify      | 30     | 0      | 2       | 0     | 32    | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Package     | 19     | 0      | 12      | 0     | 31    | ✅     |
    | Data Stores | 31     | 0      | 0       | 0     | 31    | ✅     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Fulfillment | 1      | 0      | 0       | 0     | 1     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 339    | 0      | 27      | 0     | 366   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-cng: :white_check_mark: test report for 93a1a6ad

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Create      | 139    | 0      | 15      | 0     | 154   | ✅     |
    | Govern      | 79     | 0      | 9       | 0     | 88    | ✅     |
    | Data Stores | 34     | 0      | 9       | 0     | 43    | ✅     |
    | Plan        | 83     | 0      | 6       | 0     | 89    | ✅     |
    | Verify      | 55     | 0      | 11      | 0     | 66    | ✅     |
    | Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Package     | 23     | 0      | 15      | 0     | 38    | ✅     |
    | Manage      | 2      | 0      | 8       | 0     | 10    | ✅     |
    | Fulfillment | 2      | 0      | 24      | 0     | 26    | ✅     |
    | Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
    | Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Secure      | 3      | 0      | 1       | 0     | 4     | ✅     |
    | Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
    | Ai-powered  | 0      | 0      | 1       | 0     | 1     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 435    | 0      | 118     | 0     | 553   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :x: test report for 93a1a6ad

    expand test summary
    +---------------------------------------------------------------------+
    |                           suites summary                            |
    +----------------+--------+--------+---------+-------+-------+--------+
    |                | passed | failed | skipped | flaky | total | result |
    +----------------+--------+--------+---------+-------+-------+--------+
    | Govern         | 108    | 1      | 8       | 0     | 117   | ❌     |
    | Systems        | 7      | 0      | 0       | 0     | 7     | ✅     |
    | Plan           | 88     | 0      | 6       | 0     | 94    | ✅     |
    | Manage         | 30     | 0      | 15      | 0     | 45    | ✅     |
    | GitLab Metrics | 2      | 0      | 1       | 0     | 3     | ✅     |
    | Create         | 425    | 0      | 45      | 2     | 470   | ✅     |
    | Verify         | 55     | 0      | 11      | 0     | 66    | ✅     |
    | Configure      | 1      | 0      | 3       | 0     | 4     | ✅     |
    | Analytics      | 3      | 0      | 0       | 0     | 3     | ✅     |
    | Package        | 31     | 0      | 14      | 4     | 45    | ✅     |
    | Fulfillment    | 4      | 0      | 24      | 0     | 28    | ✅     |
    | Data Stores    | 47     | 0      | 10      | 0     | 57    | ✅     |
    | Ai-powered     | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Monitor        | 12     | 0      | 13      | 0     | 25    | ✅     |
    | Release        | 5      | 0      | 1       | 0     | 6     | ✅     |
    | Secure         | 3      | 0      | 1       | 0     | 4     | ✅     |
    | ModelOps       | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Growth         | 0      | 0      | 2       | 0     | 2     | ➖     |
    +----------------+--------+--------+---------+-------+-------+--------+
    | Total          | 821    | 1      | 157     | 6     | 979   | ❌     |
    +----------------+--------+--------+---------+-------+-------+--------+
  • SAM FIGUEROA added 1 commit

    added 1 commit

    • 2b2a0e5f - Rename for reauthentication vs just password

    Compare with previous version

  • SAM FIGUEROA
  • SAM FIGUEROA added 1290 commits

    added 1290 commits

    Compare with previous version

  • A deleted user added documentation label

    added documentation label

  • SAM FIGUEROA added 2007 commits

    added 2007 commits

    Compare with previous version

  • SAM FIGUEROA marked this merge request as ready

    marked this merge request as ready

  • SAM FIGUEROA requested review from @eread and @hraghuvanshi

    requested review from @eread and @hraghuvanshi

  • Evan Read
  • Evan Read
  • Evan Read
  • Evan Read
  • Evan Read
  • Evan Read
  • Evan Read
  • Evan Read changed milestone to %17.0

    changed milestone to %17.0

  • Evan Read removed review request for @eread

    removed review request for @eread

  • Evan Read requested changes

    requested changes

  • Evan Read changed milestone to %17.1

    changed milestone to %17.1

  • SAM FIGUEROA added 1 commit

    added 1 commit

    • 3b29ed37 - Update docs with TW feedback

    Compare with previous version

  • SAM FIGUEROA added 1 commit

    added 1 commit

    • 1f56361d - Update docs with TW feedback

    Compare with previous version

  • SAM FIGUEROA added 1 commit

    added 1 commit

    • 29df4b20 - Rename for reauthentication vs just password

    Compare with previous version

  • Hitesh Raghuvanshi removed review request for @hraghuvanshi

    removed review request for @hraghuvanshi

  • Hitesh Raghuvanshi
  • Hitesh Raghuvanshi
  • Hitesh Raghuvanshi
  • Hitesh Raghuvanshi requested changes

    requested changes

  • Evan Read mentioned in merge request !153923 (merged)

    mentioned in merge request !153923 (merged)

  • SAM FIGUEROA mentioned in commit 2b4cfbb1

    mentioned in commit 2b4cfbb1

  • SAM FIGUEROA added 2150 commits

    added 2150 commits

    Compare with previous version

  • SAM FIGUEROA requested review from @hraghuvanshi

    requested review from @hraghuvanshi

  • SAM FIGUEROA mentioned in epic &12035

    mentioned in epic &12035

  • SAM FIGUEROA added 1 commit

    added 1 commit

    • abf883ec - Change feature category for audit event

    Compare with previous version

  • SAM FIGUEROA added 1 commit

    added 1 commit

    • 55bd90dc - Change feature category for audit event

    Compare with previous version

  • Hitesh Raghuvanshi
  • Hitesh Raghuvanshi
  • Hitesh Raghuvanshi
  • Hitesh Raghuvanshi
  • Hitesh Raghuvanshi
  • Hitesh Raghuvanshi
  • Hitesh Raghuvanshi
  • Hitesh Raghuvanshi removed review request for @hraghuvanshi

    removed review request for @hraghuvanshi

  • SAM FIGUEROA mentioned in commit ed8f7d4b

    mentioned in commit ed8f7d4b

  • SAM FIGUEROA added 1379 commits

    added 1379 commits

    Compare with previous version

  • SAM FIGUEROA mentioned in commit 2c20801d

    mentioned in commit 2c20801d

  • SAM FIGUEROA added 1 commit

    added 1 commit

    • 2c20801d - Rename for reauthentication vs just password

    Compare with previous version

  • SAM FIGUEROA mentioned in commit b2ae385d

    mentioned in commit b2ae385d

  • SAM FIGUEROA added 1 commit

    added 1 commit

    • b2ae385d - Rename for reauthentication vs just password

    Compare with previous version

  • SAM FIGUEROA requested review from @hraghuvanshi

    requested review from @hraghuvanshi

  • requested review from @a_akgun

  • Hitesh Raghuvanshi approved this merge request

    approved this merge request

  • added pipelinetier-3 label and removed pipelinetier-1 label

  • Hitesh Raghuvanshi removed review request for @hraghuvanshi

    removed review request for @hraghuvanshi

  • :tools: Generated by gitlab_quality-test_tooling.


    :snail: Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.

    Click to expand
    Job File Name Duration Expected duration
    #7057240679 spec/lib/release_highlights/validator_spec.rb#L82 ReleaseHighlights::Validator when validating all files they should have no errors 71.18 s < 27.12 s
    #7096332990 spec/lib/release_highlights/validator_spec.rb#L82 ReleaseHighlights::Validator when validating all files they should have no errors 70.46 s < 27.12 s
    #7096333263 ee/spec/lib/ee/search/settings_spec.rb#L19 Search results for settings behaves like all sections exist and have correct anchor links has only valid settings sections 49.95 s < 27.12 s
    #7096692007 spec/lib/release_highlights/validator_spec.rb#L82 ReleaseHighlights::Validator when validating all files they should have no errors 76.68 s < 27.12 s
    #7110796891 ee/spec/lib/ee/search/settings_spec.rb#L19 Search results for settings behaves like all sections exist and have correct anchor links has only valid settings sections 36.94 s < 27.12 s
    #7110796787 spec/lib/search/settings_spec.rb#L6 Search results for settings behaves like all sections exist and have correct anchor links has only valid settings sections 47.02 s < 27.12 s
    #7110796754 spec/lib/release_highlights/validator_spec.rb#L82 ReleaseHighlights::Validator when validating all files they should have no errors 86.61 s < 27.12 s
    #7110975769 spec/lib/release_highlights/validator_spec.rb#L82 ReleaseHighlights::Validator when validating all files they should have no errors 65.28 s < 27.12 s
    #7110975923 ee/spec/lib/ee/search/settings_spec.rb#L19 Search results for settings behaves like all sections exist and have correct anchor links has only valid settings sections 45.34 s < 27.12 s
    #7110975785 spec/lib/search/settings_spec.rb#L6 Search results for settings behaves like all sections exist and have correct anchor links has only valid settings sections 30.93 s < 27.12 s
  • A deleted user added rspec:slow test detected label
  • Alper Akgun requested review from @tkuah and removed review request for @a_akgun

    requested review from @tkuah and removed review request for @a_akgun

  • Thong Kuah
  • Thong Kuah
  • Thong Kuah
  • Thong Kuah
  • Thong Kuah removed review request for @tkuah

    removed review request for @tkuah

  • SAM FIGUEROA requested review from @tkuah

    requested review from @tkuah

  • SAM FIGUEROA mentioned in commit c01ca6d1

    mentioned in commit c01ca6d1

  • SAM FIGUEROA added 2308 commits

    added 2308 commits

    Compare with previous version

  • SAM FIGUEROA reset approvals from @hraghuvanshi by pushing to the branch

    reset approvals from @hraghuvanshi by pushing to the branch

  • Thong Kuah approved this merge request

    approved this merge request

  • Thong Kuah resolved all threads

    resolved all threads

  • Thong Kuah requested review from @eread

    requested review from @eread

  • Evan Read
  • Evan Read
  • Evan Read added 1 commit

    added 1 commit

    • 09847800 - Apply 2 suggestion(s) to 1 file(s)

    Compare with previous version

  • Evan Read approved this merge request

    approved this merge request

  • Evan Read
  • Evan Read added 1 commit

    added 1 commit

    • 93a1a6ad - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Evan Read reset approvals from @eread by pushing to the branch

    reset approvals from @eread by pushing to the branch

  • Evan Read resolved all threads

    resolved all threads

  • Thong Kuah enabled automatic add to merge train when the pipeline for 3dab0851 succeeds

    enabled automatic add to merge train when the pipeline for 3dab0851 succeeds

  • Evan Read approved this merge request

    approved this merge request

  • Looks like we had a broken master, fixed in !156450 (merged). Starting a new pipeline...

  • Thong Kuah started a merge train

    started a merge train

  • merged

  • Thong Kuah mentioned in commit 3388539e

    mentioned in commit 3388539e

  • SAM FIGUEROA mentioned in commit a6a1e0ef

    mentioned in commit a6a1e0ef

  • added workflowstaging label and removed workflowcanary label

  • SAM FIGUEROA mentioned in commit 01d37529

    mentioned in commit 01d37529

  • SAM FIGUEROA mentioned in merge request !156554 (merged)

    mentioned in merge request !156554 (merged)

  • SAM FIGUEROA mentioned in commit a0a0f4a5

    mentioned in commit a0a0f4a5

  • SAM FIGUEROA mentioned in commit 8b264109

    mentioned in commit 8b264109

  • SAM FIGUEROA mentioned in merge request !158648 (merged)

    mentioned in merge request !158648 (merged)

  • Please register or sign in to reply
    Loading