Update funnels on custom dashboards project change
What does this MR do and why?
When custom dashboard project is changed by the user, we should update the funnel records in clickhouse by
- marking the funnels from previous custom project (if any) as deleted
- marking the funnels from new custom project (if any) as created
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
funnel_custom_pointer_change_mid
How to set up and validate locally
- Create a new project and onboard product analytics. Validate the
clickhouse
database is created. - Create two other projects which has funnel definitions
- In the main project, visit project -> settings -> analytics -> Custom dashboard projects and choose one of the projects you have with funnels. Save
- Check the database
funnel_schemas
table. You should see funnels from the custom dashboard repository being created in theclickhouse
- Change the custom project to other project. You should see funnels in
clickhouse
updated - Delete the pointer
Analytics::DashboardsPointer.last.destroy!
. You should see no more records inclickhouse
funnel_schemas
Related to #438947 (closed)
Merge request reports
Activity
changed milestone to %17.0
assigned to @halilcoban
added 2050 commits
-
05ace08f...e006aee1 - 2049 commits from branch
master
- 11b75161 - Sync funnels when config project changes
-
05ace08f...e006aee1 - 2049 commits from branch
1 Warning featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
Reviewer roulette
Category Reviewer Maintainer backend @syarynovskyi
(UTC+3, 1 hour ahead of author)
@pedropombeiro
(UTC+2, same timezone as author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
Sidekiq queue changes
This merge request contains changes to Sidekiq queues. Please follow the documentation on changing a queue's urgency.
These queues were added:
product_analytics_move_funnels
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost User- Resolved by Pedro Pombeiro
- Resolved by Pedro Pombeiro
- Resolved by Pedro Pombeiro
requested review from @ssuman3
removed review request for @ssuman3
added featureenhancement label and removed featureaddition label
- Resolved by Surabhi Suman
requested review from @ssuman3