Add UI components for Beyond Identity check exclusions by Projects
What does this MR do and why?
This is the first iteration for allowing admins to exclude groups and/or projects from the Beyond Identity check.
In this iteration we:
-
Introduce a feature flag called beyond_identity_exclusions
-
List the Beyond Identity check exclusions (Projects, no backend integration) -
Ability to exclude a Project (no backend integration) -
Ability to Remove a project from the exclusion list (no backend integration) -
Documentation for exclusions by Projects will be added in a follow-up MR (once the feature is usable)
Implementation breakdown
description | MR |
---|---|
Add UI components for Beyond Identity check exclusions by Projects |
![]() |
Frontend/backend integration for Beyond Identity check exclusions by Projects + docs | follow-up MR |
Add UI components for Beyond Identity check exclusions by Groups | follow-up MR |
Frontend/backend integration for Beyond Identity check exclusions by Groups + docs | follow-up MR |
Add filtering for the Beyond Identity check exclusions list + docs | follow-up MR/issue |
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Enable the
beyond_identity_exclusions
feature flag - Navigate to Admin > Settings > Integrations
- Click on Beyond Identity > Configure
- Click on the Exclusions tab
- Click on Add exclusions to open the Add exclusions Drawer
- Search and select Projects in the drawer
- Click on Add exclusions
- The Project(s) selected in Step 6 should be added to the list of exclusions
- Removing one or more of the exclusions should remove it from the list
Related to #454372 (closed)
Merge request reports
Activity
changed milestone to %17.0
assigned to @jerasmus
- A deleted user
added feature flag label
- Resolved by Jacques Erasmus
4 Warnings This merge request is quite big (1086 lines changed), please consider splitting it into multiple merge requests. The master pipeline status page reported failures in If these jobs fail in your merge request with the same errors, then they are not caused by your changes.
Please check for any on-going incidents in the incident issue tracker or in the#master-broken
Slack channel.This merge request contains lines with testid selectors. Please ensure e2e:package-and-test
job is run.This merge request changed undocumented Vue components in
vue_shared/
. Please consider creating Stories for these components:app/assets/javascripts/vue_shared/components/list_selector/project_item.vue
app/assets/javascripts/vue_shared/components/list_selector/index.vue
testid
selectorsThe following changed lines in this MR contain
testid
selectors:app/assets/javascripts/integrations/beyond_identity/components/add_exclusions_drawer.vue
+ <h2 class="gl-font-size-h2 gl-mt-0" data-testid="title">{{ $options.i18n.addExclusions }}</h2> + data-testid="add-button"
If the
e2e:package-and-test
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start themanual:e2e-test-pipeline-generate
job in theprepare
stage and ensure the tests infollow-up:e2e:package-and-test-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Category Reviewer Maintainer frontend @mcavoj
(UTC+2, same timezone as author)
@himkp
(UTC+2, same timezone as author)
groupimport and integrate (frontend) No engineer is available for automated assignment, please reach out to the #g_manage_import_and_integrate
Slack channel or mention@gitlab-org/manage/import-and-integrate
for assistance.Maintainer review is optional for groupimport and integrate (frontend) Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
Tailwind CSS
Legacy utils
The following files contain legacy utils:
-
app/assets/javascripts/integrations/beyond_identity/components/add_exclusions_drawer.vue
gl-font-size-h2
gl-p-0!
-
app/assets/javascripts/integrations/beyond_identity/components/exclusions_list.vue
gl-display-flex
gl-align-items-center
gl-justify-content-space-between
-
app/assets/javascripts/integrations/beyond_identity/components/exclusions_list_item.vue
gl-display-flex
gl-align-items-center
gl-justify-content-space-between
gl-display-flex
gl-flex-direction-column
gl-flex-grow-1
gl-font-weight-bold
-
app/assets/javascripts/vue_shared/components/list_selector/project_item.vue
gl-display-flex
gl-align-items-center
gl-display-flex
gl-flex-direction-column
gl-flex-grow-1
gl-font-weight-bold
Use the Tailwind documentation to find the Tailwind equivalent to these legacy utils. If the Tailwind equivalent is not available it is okay to use the legacy util for now. The Tailwind equivalent will be made available when the corresponding migration issue in &13521 (closed) is completed.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits c9084782 and d373a2b4
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.31 MB 4.31 MB - 0.0 % mainChunk 3.3 MB 3.3 MB - 0.0 % Significant Growth: 1Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.admin.integrations.overrides 263.13 KB 497.47 KB +234.34 KB 89.1 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@leipert
,@markrian
,@pgascouvaillancourt
,@sdejonge
or@thutterer
) for review, if you are unsure about the size increase.Note: We do not have exact data for c9084782. So we have used data from: b99d8013.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded 1 commit
- 3b427ca8 - Add UI components for Beyond Identity check exclusions
added 1 commit
- 1ec1313d - Add UI components for Beyond Identity check exclusions
added 1 commit
- 257fa6bd - Add UI components for Beyond Identity check exclusions
added 1 commit
- 9cd33491 - Add UI components for Beyond Identity check exclusions
added 1 commit
- 1192e047 - Add UI components for Beyond Identity check exclusions
added 1 commit
- 2fb6ae5e - Add UI components for Beyond Identity check exclusions
added 1 commit
- 94023e73 - Add UI components for Beyond Identity check exclusions
added 1 commit
- c5e7ccd2 - Add UI components for Beyond Identity check exclusions
mentioned in merge request !150807 (merged)
- Resolved by Jacques Erasmus
requested review from @mle
- Resolved by Jacques Erasmus
Hi @msedlakjakubowski, could you please review the UI text changes when you get a chance?
This MR is not ready for a code review just yet, but the UI should be ready so I wanted to get a head start on UI reviews.
Also, since we're not integrating with the backend in this MR, I decided to add the documentation for the feature in a follow-up (once the feature becomes usable), but happy to move the documentation updates to this MR if you think it's better.
Edited by Jacques Erasmus
requested review from @msedlakjakubowski
- Resolved by Jacques Erasmus
Hi @nradina, could you please review the frontend changes when you get a chance?
Once approved, please pass it on to
@justin_ho
as maintainer in groupimport and integrate.
requested review from @nradina