Skip to content

Add labels/reviewers to OverdueFinalizeBackgroundMigration keep

Dylan Griffith requested to merge finalize-migration-keep-reviewer-and-labels into master

What does this MR do and why?

Context

This MR makes a few changes to existing housekeeper keeps.

These keeps are scripts we run periodically to clean up overdue tasks in the GitLab codebase. The housekeeper creates an MR when these are run.

Change

  1. We update the OverdueFinalizeBackgroundMigration keep to set labels and a reviewer based on the feature category
  2. This is done by using the same code that was in RemoveDuplicatedIndexes so it is now extracted to helpers in ::Keeps::Helpers::Groups
  3. In testing the changes to RemoveDuplicatedIndexes I noticed that it was recently broken because we added an initialize method to the super Keep class and the arguments no longer matched in the override. There was also another issue with calling Shell as it did not like being passed a Hash. I'm not sure when that broke but I also fixed that while I was here

This does not change anything about the running GitLab rails application. It only changes our housekeeper jobs that run in separate CI pipelines.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Dylan Griffith

Merge request reports