Skip to content

Support GitLab flavored markdown in finding modal description

Lorenz van Herwaarden requested to merge support-gfm-description-finding-modal into master

What does this MR do and why?

Related #454141 (closed)

Support GitLab flavored markdown in finding modal description.

Changelog: added EE: true

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
before-description after-description

How to set up and validate locally

Prerequisites

  1. You need an EE license
  2. You need to have runners enabled (See $2408961 for setting up a runner)
  3. Import https://gitlab.com/lorenzvanherwaarden/test-remediations-with-markdown-description (❗ different than default security-reports repo)
  4. Run a pipeline on master

Validate

  1. Go to the latest pipeline > security tab
  2. Click the critical finding to open the finding modal
  3. Validate that the modal's Description part contains the markdown, including a rendered mermaid diagram and the addition is green instead of blue
Edited by Lorenz van Herwaarden

Merge request reports