POC: Add /remind_me quick action
What does this MR do and why?
This proof-of-concept adds a new quick action /remind_me <date in future>
that will create a Notification/ToDo at the scheduled time. It uses scheduled Sidekiq jobs to create a ToDo
for the user. It was built in this manner as an exercise in a fast
Screenshots
Command hinting
Reminder set
ToDo
Related to #20490
Merge request reports
Activity
assigned to @kerrizor
added linked-issue label
- A deleted user
added backend feature flag labels
- Resolved by Kerri Miller
3 Warnings 2abd4584: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. d5e55a4f: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. 82649d4a: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. 1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer analytics instrumentation @bastirehm
(UTC+2, 9 hours ahead of author)
Maintainer review is optional for analytics instrumentation backend @ddieulivol
(UTC+2, 9 hours ahead of author)
@brytannia
(UTC+2, 9 hours ahead of author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
Sidekiq queue changes
This merge request contains changes to Sidekiq queues. Please follow the documentation on changing a queue's urgency.
These queues were added:
issuable_create_reminder
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 159 commits
-
55e01e31...620482f1 - 156 commits from branch
master
- 0df345af - WIP
- c49eacbe - Add strings
- 2f2f523a - Update feature flag YML
Toggle commit list-
55e01e31...620482f1 - 156 commits from branch
- A deleted user
added 5 commits
Toggle commit listremoved groupproject management label
added groupcode review label
- Resolved by Kerri Miller
@bastirehm could you review this to ensure I've done the instrumentation correctly?
requested review from @bastirehm
- Resolved by Kerri Miller
@dskim_gitlab could I trouble you for an initial review here?
requested review from @dskim_gitlab
- Resolved by Kerri Miller
- Resolved by Tetiana Chupryna
@phikai any changes to the language you'd recommend here?
removed [deprecated] Accepting merge requests label
removed review request for @dskim_gitlab
added analytics instrumentationapproved label and removed analytics instrumentationreview pending label
added pipeline:mr-approved label
- Resolved by Kerri Miller
@bastirehm
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 119a9de2expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 51 | 0 | 2 | 0 | 53 | ✅ | | Create | 96 | 0 | 9 | 0 | 105 | ✅ | | Package | 24 | 0 | 6 | 0 | 30 | ✅ | | Govern | 66 | 0 | 0 | 0 | 66 | ✅ | | Monitor | 7 | 0 | 0 | 0 | 7 | ✅ | | Verify | 35 | 0 | 1 | 0 | 36 | ✅ | | Data Stores | 31 | 0 | 0 | 0 | 31 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 317 | 0 | 19 | 0 | 336 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 119a9de2expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 285 | 0 | 23 | 0 | 308 | ✅ | | Create | 182 | 0 | 21 | 0 | 203 | ✅ | | Package | 6 | 0 | 8 | 0 | 14 | ✅ | | Govern | 28 | 0 | 0 | 0 | 28 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Release | 2 | 0 | 0 | 0 | 2 | ✅ | | Verify | 18 | 0 | 0 | 0 | 18 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 551 | 0 | 52 | 0 | 603 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
added 331 commits
-
e9d73a35...dbb78d77 - 317 commits from branch
master
- dbb78d77...4da433f0 - 4 earlier commits
- c13eddc0 - Move /remind_me to issuables
- f60b63d9 - Add metrics tracking definitions
- 23c24f4b - Move /remind_me back to issue/MR file
- e80ca3c5 - Pass class name to worker
- b94c5cc6 - Add basic worker that creates todo against target
- 60fe2fe8 - Update worker queues to include issuable_create_reminder
- 82402c96 - Update sidekiq_queues to include issuable_create_reminder
- 477d8c3c - Pass target class as string
- 0f4f1ebf - Add basic spec for CreateReminderWorker
- d18cd4a6 - Conflict resolution in gitlab.pot
Toggle commit list-
e9d73a35...dbb78d77 - 317 commits from branch
- Resolved by Kerri Miller
added pipeline:skip-undercoverage label
changed milestone to %17.0
requested review from @brytannia
requested review from @aqualls
reset approvals from @dskim_gitlab by pushing to the branch
added 175 commits
-
220d003b...483cab8c - 158 commits from branch
master
- 483cab8c...9955a813 - 7 earlier commits
- 2aee79e6 - Pass class name to worker
- ca6a214a - Add basic worker that creates todo against target
- b871d2b1 - Update worker queues to include issuable_create_reminder
- c472bbac - Update sidekiq_queues to include issuable_create_reminder
- df9e82d2 - Pass target class as string
- 8e1eec7d - Add basic spec for CreateReminderWorker
- e04c2c0a - Conflict resolution in gitlab.pot
- 1a8b2785 - Use correct product area name
- 2e8ff50b - Fix aggregate counter error
- 6b61c4b7 - To-Do > ToDo
Toggle commit list-
220d003b...483cab8c - 158 commits from branch
mentioned in issue #20490
removed review request for @bastirehm
- Resolved by Tetiana Chupryna
- Resolved by Tetiana Chupryna
- Resolved by Amy Qualls
heyo @kerrizor! I LIKE THIS AND MY QUESTIONS ARE SMALL.
the command itself
question (non-blocking): Wouldn't the
_me
portion of/remind_me
be implied? I checked https://docs.gitlab.com/ee/user/project/quick_actions.html and we don't use it in any of the other commands. It's a tiny bit of simplification that will probably avoid quite a few instances of/remind-me 1w
with a dash instead of an underscore.
- Resolved by Tetiana Chupryna
I left suggestions, and they're boring.
sensible default?
question (non-blocking): What happens if the user adds
/remind_me
(or just/remind
, hee) but doesn't specify a date? What's the default? If we don't have one, I vote for one week. We can always change / mangle this later…
added UI text tw-weight3 twfinished labels
removed review request for @aqualls
Hi
@aqualls
,GitLab Bot has added the Technical Writing label because a Technical Writer has approved or merged this MR.
This message was generated automatically. You're welcome to improve it.
added Technical Writing label
added 87 commits
-
6b61c4b7...b6bb01e0 - 69 commits from branch
master
- b6bb01e0...b13054db - 8 earlier commits
- db050ac2 - Add basic worker that creates todo against target
- 05a1befd - Update worker queues to include issuable_create_reminder
- 31374254 - Update sidekiq_queues to include issuable_create_reminder
- 77430d60 - Pass target class as string
- c62b7ec3 - Add basic spec for CreateReminderWorker
- 3c1764c8 - Conflict resolution in gitlab.pot
- 3a436f12 - Use correct product area name
- 0e457b6b - Fix aggregate counter error
- ec90805c - To-Do > ToDo
- 119a9de2 - Lowercase some items and clarify text
Toggle commit list-
6b61c4b7...b6bb01e0 - 69 commits from branch
reset approvals from @brytannia by pushing to the branch
unassigned @kerrizor
assigned to @kerrizor
enabled an automatic merge when the pipeline for b974f583 succeeds
- Resolved by Tetiana Chupryna
@brytannia, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 4 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to auto-merge.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
This message was generated automatically. You're welcome to improve it.
@kerrizor, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:
- React with a
or a on this comment to describe your experience. - Create a new comment starting with
@gitlab-bot feedback
below, and leave any additional feedback you have for us in the comment.
Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.
Thanks for your help!
This message was generated automatically. You're welcome to improve it.
- React with a
mentioned in commit 913caba5
mentioned in issue #457815 (closed)
mentioned in issue #457817 (closed)
mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#6035 (closed)
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added releasedcandidate label
- Resolved by Kerri Miller
added pipelinetier-3 label
added releasedpublished label and removed releasedcandidate label
mentioned in issue gitlab-org/quality/triage-reports#20630 (closed)
mentioned in issue gitlab-org/quality/triage-reports#20961 (closed)
mentioned in issue gitlab-org/quality/triage-reports#21526 (closed)
mentioned in issue gitlab-org/quality/triage-reports#22007 (closed)