Skip to content
Snippets Groups Projects

POC: Add /remind_me quick action

Merged Kerri Miller requested to merge 20490-add-remind-quick-action into master
All threads resolved!

What does this MR do and why?

This proof-of-concept adds a new quick action /remind_me <date in future> that will create a Notification/ToDo at the scheduled time. It uses scheduled Sidekiq jobs to create a ToDo for the user. It was built in this manner as an exercise in a fast :iteration: experiment to gather feedback and interest before committing to a scheduled wider release.

Screenshots

Command hinting

image

Reminder set

image

ToDo

image

Related to #20490

Edited by Kerri Miller

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • 3 Warnings
    :warning: 2abd4584: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
    :warning: d5e55a4f: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
    :warning: 82649d4a: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
    1 Message
    :book: CHANGELOG missing:

    If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog.

    If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

    Reviewer roulette

    Category Reviewer Maintainer
    analytics instrumentation @bastirehm profile link current availability (UTC+2, 9 hours ahead of author) Maintainer review is optional for analytics instrumentation
    backend @ddieulivol profile link current availability (UTC+2, 9 hours ahead of author) @brytannia profile link current availability (UTC+2, 9 hours ahead of author)

    Please check reviewer's status!

    • available Reviewer is available!
    • unavailable Reviewer is unavailable!

    Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

    Sidekiq queue changes

    This merge request contains changes to Sidekiq queues. Please follow the documentation on changing a queue's urgency.

    These queues were added:

    • issuable_create_reminder

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Kerri Miller added 1 commit

    added 1 commit

    Compare with previous version

  • Kerri Miller resolved all threads

    resolved all threads

  • Kerri Miller added 159 commits

    added 159 commits

    Compare with previous version

  • Kerri Miller added 1 commit

    added 1 commit

    • 9e31787d - Move /remind_me to issue & MR actions

    Compare with previous version

  • Kerri Miller added 1 commit

    added 1 commit

    • 86a95b16 - Move /remind_me to issuables

    Compare with previous version

  • Kerri Miller added 1 commit

    added 1 commit

    • a0e9098b - Add metrics tracking definitions

    Compare with previous version

  • Kerri Miller added 5 commits

    added 5 commits

    • 0bd17f98 - Move /remind_me back to issue/MR file
    • 5f3cad42 - Pass class name to worker
    • 193bdffa - Add basic worker that creates todo against target
    • 8a6cbe7f - Update worker queues to include issuable_create_reminder
    • bfe28d8c - Update sidekiq_queues to include issuable_create_reminder

    Compare with previous version

  • Kerri Miller added 1 commit

    added 1 commit

    Compare with previous version

  • Kerri Miller marked this merge request as ready

    marked this merge request as ready

  • Kerri Miller changed the description

    changed the description

  • Kerri Miller requested review from @bastirehm

    requested review from @bastirehm

  • Kerri Miller added 1 commit

    added 1 commit

    • e9d73a35 - Add basic spec for CreateReminderWorker

    Compare with previous version

  • requested review from @dskim_gitlab

  • Kerri Miller
  • removed review request for @dskim_gitlab

  • Kerri Miller changed title from Add /remind_me quick action to POC: Add /remind_me quick action

    changed title from Add /remind_me quick action to POC: Add /remind_me quick action

  • Sebastian Rehm approved this merge request

    approved this merge request

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 119a9de2

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Plan        | 51     | 0      | 2       | 0     | 53    | ✅     |
    | Create      | 96     | 0      | 9       | 0     | 105   | ✅     |
    | Package     | 24     | 0      | 6       | 0     | 30    | ✅     |
    | Govern      | 66     | 0      | 0       | 0     | 66    | ✅     |
    | Monitor     | 7      | 0      | 0       | 0     | 7     | ✅     |
    | Verify      | 35     | 0      | 1       | 0     | 36    | ✅     |
    | Data Stores | 31     | 0      | 0       | 0     | 31    | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 317    | 0      | 19      | 0     | 336   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :white_check_mark: test report for 119a9de2

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Plan        | 285    | 0      | 23      | 0     | 308   | ✅     |
    | Create      | 182    | 0      | 21      | 0     | 203   | ✅     |
    | Package     | 6      | 0      | 8       | 0     | 14    | ✅     |
    | Govern      | 28     | 0      | 0       | 0     | 28    | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Release     | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Verify      | 18     | 0      | 0       | 0     | 18    | ✅     |
    | Data Stores | 22     | 0      | 0       | 0     | 22    | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 551    | 0      | 52      | 0     | 603   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • Kerri Miller added 331 commits

    added 331 commits

    • e9d73a35...dbb78d77 - 317 commits from branch master
    • dbb78d77...4da433f0 - 4 earlier commits
    • c13eddc0 - Move /remind_me to issuables
    • f60b63d9 - Add metrics tracking definitions
    • 23c24f4b - Move /remind_me back to issue/MR file
    • e80ca3c5 - Pass class name to worker
    • b94c5cc6 - Add basic worker that creates todo against target
    • 60fe2fe8 - Update worker queues to include issuable_create_reminder
    • 82402c96 - Update sidekiq_queues to include issuable_create_reminder
    • 477d8c3c - Pass target class as string
    • 0f4f1ebf - Add basic spec for CreateReminderWorker
    • d18cd4a6 - Conflict resolution in gitlab.pot

    Compare with previous version

  • Kerri Miller
  • Kerri Miller added 1 commit

    added 1 commit

    • 9283a5df - Use correct product area name

    Compare with previous version

  • Kerri Miller added 1 commit

    added 1 commit

    Compare with previous version

  • Kerri Miller changed the description

    changed the description

  • Sincheol (David) Kim approved this merge request

    approved this merge request

  • Kerri Miller changed milestone to %17.0

    changed milestone to %17.0

  • Kerri Miller requested review from @brytannia

    requested review from @brytannia

  • Kerri Miller requested review from @aqualls

    requested review from @aqualls

  • Kerri Miller added 1 commit

    added 1 commit

    Compare with previous version

  • Kerri Miller reset approvals from @dskim_gitlab by pushing to the branch

    reset approvals from @dskim_gitlab by pushing to the branch

  • Kerri Miller added 175 commits

    added 175 commits

    Compare with previous version

  • Donald Cook mentioned in issue #20490

    mentioned in issue #20490

  • Sebastian Rehm removed review request for @bastirehm

    removed review request for @bastirehm

  • Tetiana Chupryna
  • Tetiana Chupryna
  • Tetiana Chupryna approved this merge request

    approved this merge request

    • Resolved by Tetiana Chupryna

      I left suggestions, and they're boring.

      sensible default?

      question (non-blocking): What happens if the user adds /remind_me (or just /remind, hee) but doesn't specify a date? What's the default? If we don't have one, I vote for one week. We can always change / mangle this later…

  • Amy Qualls approved this merge request

    approved this merge request

  • Amy Qualls removed review request for @aqualls

    removed review request for @aqualls

  • Hi @aqualls :wave:,

    GitLab Bot has added the Technical Writing label because a Technical Writer has approved or merged this MR.

    This message was generated automatically. You're welcome to improve it.

  • Kerri Miller added 87 commits

    added 87 commits

    Compare with previous version

  • Kerri Miller reset approvals from @brytannia by pushing to the branch

    reset approvals from @brytannia by pushing to the branch

  • Tetiana Chupryna resolved all threads

    resolved all threads

  • Tetiana Chupryna approved this merge request

    approved this merge request

  • Tetiana Chupryna enabled an automatic merge when the pipeline for b974f583 succeeds

    enabled an automatic merge when the pipeline for b974f583 succeeds

  • @kerrizor, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:

    1. React with a :thumbsup: or a :thumbsdown: on this comment to describe your experience.
    2. Create a new comment starting with @gitlab-bot feedback below, and leave any additional feedback you have for us in the comment.

    Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.

    Thanks for your help! :heart:

    This message was generated automatically. You're welcome to improve it.

  • mentioned in commit 913caba5

  • mentioned in issue #457815 (closed)

  • mentioned in issue #457817 (closed)

  • added workflowstaging label and removed workflowcanary label

  • Tetiana Chupryna resolved all threads

    resolved all threads

  • Peter Leitzen
  • Peter Leitzen resolved all threads

    resolved all threads

  • Please register or sign in to reply
    Loading