Skip to content

Modify FindingResolver to use PureFindingsFinder

Malcolm Locke requested to merge 456395-finding-resolver-pure-finder into master

In Replace `Security::FindingsFinder` with `Securi... (#444309) we will replace the existing deprecated behaviour of Security::FindingsFinder with the behaviour of Security::PureFindingsFinder. Most callers of these finders have been conditionally calling either one finder or the other based upon the availability of the backing data in the database for Security::PureFindingsFinder. For some time all of these conditional calls will have been using the pure finder as all findings now have the data in the database.

However, Resolvers::SecurityReport::FindingResolver is an outlier because it has unconditionally been using the old deprecated finder.

This MR switches the resolver to using the newer Security::PureFindingsFinder. The new behaviour is behind a feature flag in case there are any edge case regression not covered by the test suite.

Related to #456395 (closed)

Edited by Malcolm Locke

Merge request reports