Use GITLAB_LOG_LEVEL for Geo logs
What does this MR do and why?
The Geo log level is tied to Rails log level, which is set to info, and I think GitLab doesn't provide a way to modify it. GitLab does provide GITLAB_LOG_LEVEL
https://docs.gitlab.com/ee/administration/logs/index.html#override-default-log-level.
This MR makes geo.log
output abide by GITLAB_LOG_LEVEL
.
Related to &6034
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Configure Geo if you haven't already
- Add a
env.runit
file to the root directory of both GDK directories - Add a line
export GITLAB_LOG_LEVEL=warn
to bothenv.runit
files -
gdk restart
both GDKs - Observe logs with and without the environment variable set
You should see that if you set it to e.g. warn
, then the services no longer output debug
and info
level logs.
I checked that for example error
level is still output by manually modifying the checksum of a project repository in the project_states
table in the primary site and then reverifying the project on the secondary site. It did output the error
level log message as expected.
Merge request reports
Activity
changed milestone to %17.0
added backend featureenhancement groupgeo typefeature labels
assigned to @mkozono
added devopssystems sectioncore platform labels
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/administration/logs/index.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Category Reviewer Maintainer backend @tyleramos
(UTC-4, 6 hours ahead of author)
@nicolasdular
(UTC+2, 12 hours ahead of author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost User-
- A deleted user
added documentation label
added 2 commits
- Resolved by Nicolas Dular
@tyleramos Would you please review?
requested review from @tyleramos
added pipeline:mr-approved label
- Resolved by Nicolas Dular
@tyleramos
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
- Resolved by Nicolas Dular
@nicolasdular Would you mind running the maintainer review when you have time?
requested review from @nicolasdular and removed review request for @tyleramos
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for c827289cexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 87 | 0 | 9 | 0 | 96 | ✅ | | Govern | 66 | 0 | 0 | 0 | 66 | ✅ | | Plan | 51 | 0 | 2 | 0 | 53 | ✅ | | Data Stores | 31 | 0 | 0 | 0 | 31 | ✅ | | Verify | 35 | 0 | 1 | 0 | 36 | ✅ | | Package | 24 | 0 | 6 | 0 | 30 | ✅ | | Monitor | 7 | 0 | 0 | 0 | 7 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 308 | 0 | 19 | 0 | 327 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for c827289cexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Systems | 10 | 0 | 0 | 1 | 10 | ✅ | | Create | 46 | 0 | 6 | 0 | 52 | ✅ | | Govern | 28 | 0 | 0 | 0 | 28 | ✅ | | Plan | 44 | 0 | 4 | 0 | 48 | ✅ | | Verify | 18 | 0 | 0 | 0 | 18 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Package | 6 | 0 | 8 | 0 | 14 | ✅ | | Release | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 184 | 0 | 18 | 1 | 202 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost User