Add edit button to policies
What does this MR do and why?
This MR adds edit button to list of policies in edit compliance framework screen
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
How to set up and validate locally
- Enable experiment
Security policy scope
under your groupSettings
General
Permissions and group features
- Open
Security
Compliance center
,Frameworks
tab - Create compliance framework
- Create few policies under
Security
Policies
and link them to one of frameworks - Edit compliance framework
- Observe "Edit buttons" under policies list
Related to #451969 (closed)
Merge request reports
Activity
changed milestone to %17.0
assigned to @xanf
added 1 commit
- 1f1740f7 - Add edit button to policies list in edit screen
Reviewer roulette
Category Reviewer Maintainer frontend @janis
(UTC+2, 1 hour behind author)
@dmishunov
(UTC+2, 1 hour behind author)
UX @cam.x
(UTC+0, 3 hours behind author)
Maintainer review is optional for UX Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost UserBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits cef98821 and 1f1740f7
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.3 MB 4.3 MB - 0.0 % mainChunk 3.3 MB 3.3 MB - 0.0 %
Note: We do not have exact data for cef98821. So we have used data from: 398163a6.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by Ghost User- Resolved by Denys Mishunov
@janis, could you please review this tiny one?
requested review from @janis
requested review from @dmishunov and removed review request for @janis
added pipeline:mr-approved label
- Resolved by Denys Mishunov
@janis
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 1f1740f7expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Data Stores | 31 | 0 | 0 | 0 | 31 | ✅ | | Package | 24 | 0 | 6 | 0 | 30 | ✅ | | Create | 87 | 0 | 9 | 0 | 96 | ✅ | | Plan | 51 | 0 | 2 | 0 | 53 | ✅ | | Govern | 66 | 0 | 0 | 0 | 66 | ✅ | | Verify | 35 | 0 | 1 | 0 | 36 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Monitor | 7 | 0 | 0 | 0 | 7 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 308 | 0 | 19 | 0 | 327 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 1f1740f7expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 300 | 0 | 13 | 5 | 313 | ✅ | | Create | 181 | 1 | 21 | 2 | 203 | ❌ | | Plan | 44 | 0 | 4 | 0 | 48 | ✅ | | Release | 2 | 0 | 0 | 0 | 2 | ✅ | | Verify | 18 | 0 | 0 | 0 | 18 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Package | 6 | 0 | 8 | 0 | 14 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 581 | 1 | 46 | 7 | 628 | ❌ | +-------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost Userenabled an automatic merge when the pipeline for c38de55e succeeds