Clean up duo_pro_trials_for_free_plans feature flag
What does this MR do and why?
duo_pro_trials_for_free_plans
feature flag was never enabled. Removing duo_pro_trials_for_free_plans
FF since right now there is no firm decision to add Duo Pro for free plans
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
How to set up and validate locally
- Setup GDK to simulate SaaS.
bin/rails c
Feature.enable(:duo_pro_trials)
- Sign in. Create new group on free plan.
- Visit billing page.
- Make sure there is no
Start a free GitLab Duo Pro trial
button.
Related to #454861
Merge request reports
Activity
changed milestone to %17.0
assigned to @syarynovskyi
1 Warning The master pipeline status page reported failures in If these jobs fail in your merge request with the same errors, then they are not caused by your changes.
Please check for any on-going incidents in the incident issue tracker or in the#master-broken
Slack channel.Reviewer roulette
Category Reviewer Maintainer backend @janis
(UTC+2, 1 hour behind author)
@wandering_person
(UTC+7, 4 hours ahead of author)
frontend @nradina
(UTC+2, 1 hour behind author)
@himkp
(UTC+2, 1 hour behind author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Useradded workflowin review label and removed workflowin dev label
- Resolved by Felipe Cardozo
@minahilnichols Could you pls review backend ?
PS Since there are very few changes, I think we can skip frontend review.
requested review from @minahilnichols
requested review from @ifarkas and removed review request for @minahilnichols
added pipeline:mr-approved label
- Resolved by Felipe Cardozo
@minahilnichols
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for fdf64867expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 66 | 0 | 0 | 0 | 66 | ✅ | | Plan | 51 | 0 | 2 | 0 | 53 | ✅ | | Create | 87 | 0 | 9 | 0 | 96 | ✅ | | Data Stores | 31 | 0 | 0 | 0 | 31 | ✅ | | Package | 24 | 0 | 6 | 0 | 30 | ✅ | | Verify | 35 | 0 | 1 | 0 | 36 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Monitor | 7 | 0 | 0 | 0 | 7 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 308 | 0 | 19 | 0 | 327 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for fdf64867expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Growth | 0 | 0 | 6 | 0 | 6 | ➖ | | Create | 182 | 0 | 21 | 2 | 203 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Plan | 44 | 0 | 4 | 0 | 48 | ✅ | | Package | 6 | 0 | 8 | 0 | 14 | ✅ | | Verify | 18 | 0 | 0 | 0 | 18 | ✅ | | Govern | 28 | 0 | 0 | 0 | 28 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Release | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 310 | 0 | 39 | 2 | 349 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost Userrequested review from @felipe_artur and removed review request for @ifarkas
enabled an automatic merge when the pipeline for 36a1be97 succeeds
@felipe_artur, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 4 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to auto-merge.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
This message was generated automatically. You're welcome to improve it.
mentioned in commit b16211f6
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowproduction label and removed workflowcanary label
added workflowstaging label and removed workflowproduction label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!3058 (merged)
added releasedpublished label and removed releasedcandidate label
added pipelinetier-3 label