Minor improvements with data-testid attribute

What does this MR do and why?

Minor improvements with data-testid attribute

• Reorder the order of parameters to more easily find all the primary and secondary button options.
• Extract and reuse common values in two different places.

Related with recent changes in: !148143 (merged)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

No changes.

How to set up and validate locally

1. Go to Admin Area > Applications
2. Play with the Add new application button

changed milestone to %17.0

assigned to @eduardosanz

added backend frontend labels

	1 Warning
⚠	This merge request contains lines with testid selectors. Please ensure e2e:package-and-test job is run.

testid selectors

The following changed lines in this MR contain testid selectors:

app/views/admin/applications/index.html.haml

+- button_options = { data: { testid: 'new-application-button' } }
-    primary_button_options: { data: {testid: 'new-application-button'} },
-        = render Pajamas::ButtonComponent.new(size: :small, href: new_admin_application_path, button_options: { data: { testid: 'new-application-button' } }) do

If the e2e:package-and-test job in the qa stage has run automatically, please ensure the tests are passing. If the job has not run, please start the manual:e2e-test-pipeline-generate job in the prepare stage and ensure the tests in follow-up:e2e:package-and-test-ee pipeline are passing.

For the list of known failures please refer to the latest pipeline triage issue.

If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.

Reviewer roulette

Category	Reviewer	Maintainer
backend	@tyleramos (UTC-4, 6 hours behind author)	@lauraXD (UTC+2, same timezone as author)
frontend	@fernando-c (UTC-5, 7 hours behind author)	@xanf (UTC+3, 1 hour ahead of author)

Please check reviewer's status!

• Reviewer is available!
• Reviewer is unavailable!

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the 🔁 danger-review job that generated this comment.

Generated by 🚫 Danger

Proper labels assigned to this merge request. Please ignore me.

👋 @eduardosanz - please see the following guidance and update this merge request.

	1 Error
❌	Please add typebug typefeature, or typemaintenance label to this merge request.

@lorenzvanherwaarden, please could you do the initial review? Could you pass this to @mkaeppler for the maintainer review? I believe that would be enough. Thanks, both!

requested review from @lorenzvanherwaarden

requested review from @mkaeppler and removed review request for @lorenzvanherwaarden

approved this merge request

added pipeline:mr-approved label

👋 @mkaeppler, thanks for approving this merge request.

This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break master, a new pipeline will be started shortly.

Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.

E2E Test Result Summary

allure-report-publisher generated test report!

e2e-test-on-gdk: ✅ test report for 2c40e164

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Plan        | 51     | 0      | 2       | 0     | 53    | ✅     |
| Govern      | 67     | 0      | 0       | 0     | 67    | ✅     |
| Data Stores | 31     | 0      | 0       | 0     | 31    | ✅     |
| Create      | 90     | 0      | 9       | 0     | 99    | ✅     |
| Monitor     | 7      | 0      | 0       | 0     | 7     | ✅     |
| Verify      | 35     | 0      | 1       | 0     | 36    | ✅     |
| Package     | 24     | 0      | 6       | 0     | 30    | ✅     |
| Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
| Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
| Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 312    | 0      | 19      | 0     | 331   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

e2e-package-and-test: ❌ test report for 2c40e164

expand test summary

+---------------------------------------------------------------------+
|                           suites summary                            |
+----------------+--------+--------+---------+-------+-------+--------+
|                | passed | failed | skipped | flaky | total | result |
+----------------+--------+--------+---------+-------+-------+--------+
| GitLab Metrics | 2      | 0      | 1       | 0     | 3     | ✅     |
| ModelOps       | 0      | 0      | 3       | 0     | 3     | ➖     |
| Package        | 205    | 0      | 38      | 0     | 243   | ✅     |
| Verify         | 150    | 0      | 30      | 0     | 180   | ✅     |
| Govern         | 270    | 2      | 13      | 3     | 285   | ❌     |
| Create         | 570    | 0      | 81      | 10    | 651   | ✅     |
| Fulfillment    | 8      | 0      | 75      | 1     | 83    | ✅     |
| Plan           | 249    | 0      | 19      | 0     | 268   | ✅     |
| Systems        | 10     | 0      | 0       | 0     | 10    | ✅     |
| Configure      | 1      | 0      | 9       | 0     | 10    | ✅     |
| Growth         | 0      | 0      | 6       | 0     | 6     | ➖     |
| Manage         | 38     | 0      | 12      | 1     | 50    | ✅     |
| Data Stores    | 119    | 0      | 28      | 0     | 147   | ✅     |
| Analytics      | 7      | 0      | 0       | 0     | 7     | ✅     |
| Release        | 15     | 0      | 3       | 0     | 18    | ✅     |
| Monitor        | 36     | 0      | 13      | 0     | 49    | ✅     |
| Secure         | 6      | 0      | 3       | 0     | 9     | ✅     |
| Ai-powered     | 0      | 0      | 3       | 0     | 3     | ➖     |
+----------------+--------+--------+---------+-------+-------+--------+
| Total          | 1686   | 2      | 337     | 15    | 2025  | ❌     |
+----------------+--------+--------+---------+-------+-------+--------+

added maintenancerefactor typemaintenance labels

added groupauthentication label

resolved all threads

added devopsgovern sectionsec labels

enabled an automatic merge when the pipeline for b289dbd4 succeeds

merged

mentioned in commit fe2d46d4

added workflowstaging-canary label