Skip to content

Remove unnecessary div for vulnerability modal footer

Lorenz van Herwaarden requested to merge improve-finding-modal-footer into master

What does this MR do and why?

Related #443784 (closed)

The spacing between and around the modal buttons in the finding modal is larger than it should be. This MR fixes that.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
Screenshot_2024-04-15_at_00.25.44 Screenshot_2024-04-15_at_00.25.13
Screenshot_2024-04-15_at_00.25.40 Screenshot_2024-04-15_at_00.25.29

How to set up and validate locally

Prerequisites

  1. You need an EE license
  2. You need to have runners enabled (See $2408961 for setting up a runner)
  3. Import https://gitlab.com/gitlab-examples/security/security-reports
  4. Run a pipeline on master

Validate

  1. Go to lastest pipeline > security tab
  2. Click on any finding to open the vulnerability modal
  3. Inspect the modal footer and its buttons
Edited by Lorenz van Herwaarden

Merge request reports