Cleanup add_policy_approvers_to_rules feature flag

What does this MR do and why?

Cleanup add_policy_approvers_to_rules which was removed in 16.8

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Addresses #438411 (closed)

changed milestone to %16.11

added Category:Security Policy Management devopsgovern feature flag groupsecurity policies maintenanceremoval missed:16.10 missed:16.9 sectionsec typemaintenance workflowready for development labels

assigned to @sashi_kumar

removed workflowready for development label

added 1 commit

• 1c0c59b4 - Fix failing event_store_spec

Compare with previous version

added backend label

Reviewer roulette

Category	Reviewer	Maintainer
backend	@radbatnag (UTC+8, 8 hours ahead of author)	@splattael (UTC+2, 2 hours ahead of author)

Please check reviewer's status!

• Reviewer is available!
• Reviewer is unavailable!

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

@mcavoj Would you mind taking a look at this?

Since the worker Security::RefreshProjectPoliciesWorker is no longer used, we can try to remove in %17.0

requested review from @mcavoj

requested review from @ahmed.hemdan and removed review request for @mcavoj

approved this merge request

added pipeline:mr-approved label

@mcavoj, thanks for approving this merge request.

This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break master, a new pipeline will be started shortly.

Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.

E2E Test Result Summary

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for 1c0c59b4

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Create      | 90     | 0      | 9       | 0     | 99    | ✅     |
| Govern      | 66     | 0      | 0       | 0     | 66    | ✅     |
| Verify      | 35     | 0      | 1       | 0     | 36    | ✅     |
| Monitor     | 7      | 0      | 0       | 0     | 7     | ✅     |
| Data Stores | 31     | 0      | 0       | 0     | 31    | ✅     |
| Plan        | 51     | 0      | 2       | 0     | 53    | ✅     |
| Package     | 24     | 0      | 6       | 0     | 30    | ✅     |
| Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
| Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
| Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 311    | 0      | 19      | 0     | 330   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

e2e-package-and-test: test report for 1c0c59b4

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Govern      | 350    | 2      | 17      | 3     | 369   | ❌     |
| Create      | 152    | 0      | 21      | 2     | 173   | ✅     |
| Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
| Plan        | 8      | 0      | 0       | 0     | 8     | ✅     |
| Package     | 0      | 0      | 2       | 0     | 2     | ➖     |
| Data Stores | 4      | 0      | 0       | 0     | 4     | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 522    | 2      | 40      | 5     | 564   | ❌     |
+-------------+--------+--------+---------+-------+-------+--------+

requested review from @mc_rocha and removed review request for @ahmed.hemdan

approved this merge request

requested review from @splattael