Do not move "You" to front of emoji award list
requested to merge 24824-show-emoji-reaction-users-in-order-they-were-added-it-in-tooltip into master
What does this MR do and why?
This MR makes two changes to the ordering of emoji award givers in tooltips:
- The current user no longer shows up as the first user, but instead shows up in order
- When the current user is the 11th+ user to award the emoji, then the current user is moved to the 10th spot in line so that there is still indication in the tooltip that the current user has awarded this emoji
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
| Scenario | Before | After |
|---|---|---|
|
User was first to award |
|
|
|
User was 2nd ~ 9th to award |
|
|
| User was 10th+ to award |
|
|
How to set up and validate locally
- Check out this branch locally
- Go to an issue
- add any emoji reaction, making sure you are the first user to do so.
- Impersonate another user, and add the same emoji reaction. Also a few other emoji reactions.
- Stop impersonating, and as your main user, add one of the same emoji reactions the impersonation user added.
- Impersonate 10 users in a row, and with each impersonated user, add one of the same emoji reactions that the user in step 4 first added.
- Once the emoji reaction has been added 10 times by other users, add the same reaction using your main user. Your user will be the 11th user to add the reaction.
- hover over the emoji reactions
- You will see that for the emoji you added in step 3, "You" is first in the list of users. You were the first to add this reaction.
- You will see that for the emoji added by a different user in step 4 and then also added by your main user in step 5, "you" is second in the list. You were the second to award this.
- You will see that for the emoji that was added 11 times, "you, and 1 more..." appears at the end of the list. You were the 11th user to add this reaction, but we have pushed your entry up in the list to ensure that it appears before the cutoff in the tooltip.
Edited by Chad Lavimoniere